Add "disabled" value to EnforcementLevel #156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows disabling policies. A disabled policy is treated as if it wasn't defined, which means it will be excluded from analyzer info and when analyzing resources and the stack.
justinvp
added
the
impact/no-changelog-required
chrsmith
approved these changes
Nov 25, 2019
| @@ -130,7 +130,17 @@ export function mapEnforcementLevel(el: EnforcementLevel) { | |||
| return analyzerproto.EnforcementLevel.ADVISORY; | |||
| case "mandatory": | |||
| return analyzerproto.EnforcementLevel.MANDATORY; | |||
| // Disabled is treated as if the policy was not defined, so the value should not escape over GRPC. | |||
| case "disabled": | |||
| throw new Error("'disabled' should not escape the GRPC boundary"); | |||
There was a problem hiding this comment.
As a first step this is fine, but I think we should wire this through the CLI layer and add some comments in the protobuf. Since otherwise an alternate implementation could "leak" the "disabled" bit. Similarly, when we do hook this option up to the Pulumi Service UI, we will need to pass the "disabled" state through the CLI to the policy pack.
Read: it's fine for now, but probably not sufficient for the long run.
There was a problem hiding this comment.
Yeah we talked about this but for now its nice to not to have to touch the service!
ekrengel
approved these changes
Nov 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows disabling policies. A disabled policy is treated as if it wasn't defined, which means it will be excluded from analyzer info and when analyzing resources and the stack (i.e. the CLI and service don't need to know about
"disabled").