Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for random #872

Merged
merged 10 commits into from
Apr 10, 2024
Merged

Add tests for random #872

merged 10 commits into from
Apr 10, 2024

Conversation

VenelinMartinov
Copy link
Contributor

@VenelinMartinov VenelinMartinov commented Apr 8, 2024

pulumi/pulumi-terraform-bridge#1849

This PR adds tests for the following resources:

index_randomstring
index_randomshuffle
index_randombytes
index_randomuuid
index_randompassword
index_randomid
index_randominteger
index_randompet
It also adds upgrade tests for the resources.

Copy link

github-actions bot commented Apr 8, 2024

Does the PR have any schema changes?

Does the PR have any schema changes?

Looking good! No breaking changes found.
No new resources/functions.

Maintainer note: consult the runbook for dealing with any breaking changes.

Copy link

github-actions bot commented Apr 8, 2024

Is README.md missing any configuration options?

No missing config!

@VenelinMartinov VenelinMartinov requested a review from iwahbe April 10, 2024 11:24
@VenelinMartinov
Copy link
Contributor Author

@iwahbe this one is ready, LMK what you think and I'll merge the others as they are ready if this one looks ok.

Copy link
Member

@iwahbe iwahbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. LGTM

provider/provider_program_test.go Show resolved Hide resolved
@VenelinMartinov VenelinMartinov merged commit bed34b6 into master Apr 10, 2024
17 checks passed
@VenelinMartinov VenelinMartinov deleted the vvm/generate-tests2 branch April 10, 2024 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants