Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Downstream check script does not check for errors in upgrade-provider action #1816

Closed
VenelinMartinov opened this issue Mar 29, 2024 · 2 comments · Fixed by #1869
Closed

Downstream check script does not check for errors in upgrade-provider action #1816

VenelinMartinov opened this issue Mar 29, 2024 · 2 comments · Fixed by #1869
Assignees
@VenelinMartinov
Labels
kind/engineering Work that is not visible to an external user resolution/fixed This issue was fixed
Milestone
0.104

Comments

@VenelinMartinov
Copy link
Contributor

What happened?

After running downstream checks we then make sure that all providers succeed with the new bridge.

This can fail if the upgrade-provider action fails - we no longer raise p1s for this and the downstream_check script does not take that into account.

In this case it is benign but it could potentially cause us to miss downstream issues, especially if they are in tfgen.

Example

https://github.com/pulumi/pulumi-vault/actions/runs/8480681653/job/23236832051

Output of pulumi about

.

Additional context

No response

Contributing

Vote on this issue by adding a 👍 reaction.
To contribute a fix for this issue, leave a comment (and link to your pull request, if you've opened one already).
@VenelinMartinov VenelinMartinov added needs-triage Needs attention from the triage team kind/bug Some behavior is incorrect or out of spec labels Mar 29, 2024
@VenelinMartinov VenelinMartinov changed the title Downstream check script can fail to notice errors in upgrade-provider action Downstream check script does not check for errors in upgrade-provider action Mar 29, 2024
@iwahbe iwahbe added kind/engineering Work that is not visible to an external user and removed needs-triage Needs attention from the triage team kind/bug Some behavior is incorrect or out of spec labels Apr 3, 2024
@iwahbe iwahbe modified the milestones: 0.103, 0.104 Apr 3, 2024
@iwahbe
Copy link
Member

iwahbe commented Apr 11, 2024

ci-mgmt keeps a list of providers that should have a status at https://raw.githubusercontent.com/pulumi/ci-mgmt/master/provider-ci/providers.json. We should download that list and check that each listed item has a status (or print MISSING) if not.

@VenelinMartinov
Copy link
Contributor Author

VenelinMartinov commented Apr 11, 2024 •
edited
Loading

tfgen errors always hit this - I just hit it: https://github.com/pulumi/pulumi-aws/actions/runs/8648259460/job/23711655817

This makes tfgen changes in the bridge especially risky and the downstream checks much less informative.

@VenelinMartinov VenelinMartinov mentioned this issue Apr 12, 2024
Merged
@VenelinMartinov VenelinMartinov self-assigned this Apr 12, 2024
@VenelinMartinov VenelinMartinov mentioned this issue Apr 12, 2024
Merged
VenelinMartinov added a commit that referenced this issue Apr 12, 2024
@VenelinMartinov
Print missing repos in downstream check script (#1869)
Loading
Loading status checks…
a08acef 
fixes #1816

Hit it during
#1854

It now prints links for the repos which don't have PRs for the commit at
all:


```
FAILURE pulumi/pulumi-auth0#493
FAILURE pulumi/pulumi-oci#431
MISSING https://github.com/pulumi/pulumi-opsgenie/actions/workflows/upgrade-bridge.yml
MISSING https://github.com/pulumi/pulumi-splunk/actions/workflows/upgrade-bridge.yml
MISSING https://github.com/pulumi/pulumi-libvirt/actions/workflows/upgrade-bridge.yml
MISSING https://github.com/pulumi/pulumi-minio/actions/workflows/upgrade-bridge.yml
MISSING https://github.com/pulumi/pulumi-kafka/actions/workflows/upgrade-bridge.yml
MISSING https://github.com/pulumi/pulumi-aws/actions/workflows/upgrade-bridge.yml
MISSING https://github.com/pulumi/pulumi-onelogin/actions/workflows/upgrade-bridge.yml
MISSING https://github.com/pulumi/pulumi-cloudamqp/actions/workflows/upgrade-bridge.yml
MISSING https://github.com/pulumi/pulumi-rabbitmq/actions/workflows/upgrade-bridge.yml
MISSING https://github.com/pulumi/pulumi-newrelic/actions/workflows/upgrade-bridge.yml
MISSING https://github.com/pulumi/pulumi-dnsimple/actions/workflows/upgrade-bridge.yml
MISSING https://github.com/pulumi/pulumi-nomad/actions/workflows/upgrade-bridge.yml
MISSING https://github.com/pulumi/pulumi-mailgun/actions/workflows/upgrade-bridge.yml
MISSING https://github.com/pulumi/pulumi-mysql/actions/workflows/upgrade-bridge.yml
MISSING https://github.com/pulumi/pulumi-sumologic/actions/workflows/upgrade-bridge.yml
MISSING https://github.com/pulumi/pulumi-vsphere/actions/workflows/upgrade-bridge.yml
MISSING https://github.com/pulumi/pulumi-keycloak/actions/workflows/upgrade-bridge.yml
MISSING https://github.com/pulumi/pulumi-slack/actions/workflows/upgrade-bridge.yml
MISSING https://github.com/pulumi/pulumi-vault/actions/workflows/upgrade-bridge.yml
```
@pulumi-bot pulumi-bot added the resolution/fixed This issue was fixed label Apr 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@VenelinMartinov VenelinMartinov

Labels
kind/engineering Work that is not visible to an external user resolution/fixed This issue was fixed
Projects
None yet
Milestone
0.104
Development

Successfully merging a pull request may close this issue.

Print missing repos in downstream check script pulumi/pulumi-terraform-bridge
3 participants
@iwahbe @VenelinMartinov @pulumi-bot