Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test handling ErrorResourceInitFailed on update #2772

Closed
mjeffryes opened this issue Dec 17, 2024 · 0 comments · Fixed by #2776
Closed

Test handling ErrorResourceInitFailed on update #2772

mjeffryes opened this issue Dec 17, 2024 · 0 comments · Fixed by #2776
Assignees
@VenelinMartinov
Labels
kind/task Work that's part of an ongoing epic p1 A bug severe enough to be the next item assigned to an engineer resolution/fixed This issue was fixed

Comments

@mjeffryes
Copy link
Member

mjeffryes commented Dec 17, 2024 •
edited
Loading

In reviewing #2713, Joe pointed out that ErrorResourceInitFailed can also be returned on Update not just on Create. We should add a test that verifies we're correctly returning partial state on error for Update as well.
@mjeffryes mjeffryes added the kind/task Work that's part of an ongoing epic label Dec 17, 2024
@pulumi-bot pulumi-bot added the needs-triage Needs attention from the triage team label Dec 17, 2024
@mjeffryes mjeffryes added the p1 A bug severe enough to be the next item assigned to an engineer label Dec 17, 2024
@VenelinMartinov VenelinMartinov removed the needs-triage Needs attention from the triage team label Dec 18, 2024
@VenelinMartinov VenelinMartinov mentioned this issue Dec 18, 2024
Merged
VenelinMartinov added a commit that referenced this issue Dec 19, 2024
@VenelinMartinov
Test resource init errors during update (#2776)
662d3af 
This adds an integration test for resourceInitErrors during `Update`.
Similar to the `Create` test in
#2713

fixes #2772
@pulumi-bot pulumi-bot added the resolution/fixed This issue was fixed label Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@VenelinMartinov VenelinMartinov

Labels
kind/task Work that's part of an ongoing epic p1 A bug severe enough to be the next item assigned to an engineer resolution/fixed This issue was fixed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Test resource init errors during update pulumi/pulumi-terraform-bridge
3 participants
@mjeffryes @VenelinMartinov @pulumi-bot