Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SDKv2 Add detailed diff tests for plain attribute types #2159

Merged
merged 9 commits into from
Aug 20, 2024

Conversation

VenelinMartinov
Copy link
Contributor

@VenelinMartinov VenelinMartinov commented Jul 3, 2024

This adds integration tests around detailed diff for string, list, set and map attributes.

Quite a few issues with:

  • Handling empty collections being removed/added - these are not shown in most cases
  • Adding/removing elements being duplicated in the detailed diff output
  • Outright wrong diff for set element removed middle and set element added front similar to Wrong diff returned for removed items in TF sets #2103
  • Non-deterministic detailed diffs for set element additions/removals

Opened follow-up issues:

Related to #1895

Copy link

codecov bot commented Jul 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.98%. Comparing base (0a9542d) to head (671e6fe).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2159   +/-   ##
=======================================
  Coverage   56.98%   56.98%           
=======================================
  Files         366      366           
  Lines       50056    50056           
=======================================
+ Hits        28524    28526    +2     
+ Misses      19964    19963    -1     
+ Partials     1568     1567    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@VenelinMartinov VenelinMartinov marked this pull request as ready for review July 22, 2024 12:49
@VenelinMartinov VenelinMartinov requested a review from a team July 23, 2024 11:52
@VenelinMartinov VenelinMartinov changed the title Add detailed diff tests for plain types Add detailed diff tests for plain attribute types Jul 23, 2024
@VenelinMartinov VenelinMartinov changed the title Add detailed diff tests for plain attribute types SDKv2 Add detailed diff tests for plain attribute types Jul 23, 2024
Copy link
Member

@iwahbe iwahbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is super helpful. Thanks for putting it together.

@VenelinMartinov
Copy link
Contributor Author

Discovered another fun issue here: #2325

@VenelinMartinov VenelinMartinov merged commit 5f67f63 into master Aug 20, 2024
11 checks passed
@VenelinMartinov VenelinMartinov deleted the vvm/test_detailed_diff branch August 20, 2024 12:07
VenelinMartinov added a commit that referenced this pull request Aug 20, 2024
Comment out non-deterministic test.

This one was missed in
#2159

Tracked in #2325

fixes #2326
@pulumi-bot
Copy link
Contributor

This PR has been shipped in release v3.90.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants