-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SDKv2 Add detailed diff tests for plain attribute types #2159
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2159 +/- ##
=======================================
Coverage 56.98% 56.98%
=======================================
Files 366 366
Lines 50056 50056
=======================================
+ Hits 28524 28526 +2
+ Misses 19964 19963 -1
+ Partials 1568 1567 -1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is super helpful. Thanks for putting it together.
Discovered another fun issue here: #2325 |
This PR has been shipped in release v3.90.0. |
This adds integration tests around detailed diff for string, list, set and map attributes.
Quite a few issues with:
set element removed middle
andset element added front
similar to Wrong diff returned for removed items in TF sets #2103Opened follow-up issues:
Related to #1895