Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a test for examples replacement #2317

Merged
merged 1 commit into from
Aug 16, 2024

Conversation

iwahbe
Copy link
Member

@iwahbe iwahbe commented Aug 15, 2024

I'm adding test coverage in preparation for #2312.

@iwahbe iwahbe self-assigned this Aug 15, 2024
@iwahbe iwahbe requested a review from a team August 15, 2024 13:28
Copy link

codecov bot commented Aug 15, 2024

Codecov Report

Attention: Patch coverage is 90.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 56.94%. Comparing base (0f1e694) to head (207bba3).
Report is 4 commits behind head on master.

Files Patch % Lines
pkg/tfgen/docs.go 90.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2317   +/-   ##
=======================================
  Coverage   56.93%   56.94%           
=======================================
  Files         365      365           
  Lines       49957    49968   +11     
=======================================
+ Hits        28443    28454   +11     
+ Misses      19973    19970    -3     
- Partials     1541     1544    +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@iwahbe iwahbe force-pushed the iwahbe/add-examples-processing-tests branch from 78d53da to 5805dcf Compare August 15, 2024 15:27
Copy link
Contributor

@VenelinMartinov VenelinMartinov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

pkg/tfgen/docs.go Show resolved Hide resolved
@iwahbe iwahbe force-pushed the iwahbe/add-examples-processing-tests branch from 5805dcf to 207bba3 Compare August 16, 2024 14:44
@iwahbe iwahbe enabled auto-merge (squash) August 16, 2024 14:44
@iwahbe iwahbe merged commit a4c3698 into master Aug 16, 2024
11 checks passed
@iwahbe iwahbe deleted the iwahbe/add-examples-processing-tests branch August 16, 2024 15:03
@pulumi-bot
Copy link
Contributor

This PR has been shipped in release v3.90.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants