Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove frontmatter whitespace when trimming #2423

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: remove frontmatter whitespace when trimming #2423

wants to merge 1 commit into from

Conversation

guineveresaenger
Copy link
Contributor

Some providers have poorly formatted files. We can fix this by removing the whitespace before trimming off the remaining frontmatter.

@guineveresaenger guineveresaenger marked this pull request as draft September 17, 2024 23:04
@guineveresaenger guineveresaenger requested a review from a team September 17, 2024 23:32
@guineveresaenger guineveresaenger marked this pull request as ready for review September 17, 2024 23:32
iwahbe
iwahbe reviewed Sep 18, 2024
View reviewed changes
Copy link
Member

@iwahbe iwahbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests show that this effects the output far more then I would expect. I think we need to drill into that before merging.

@guineveresaenger
Copy link
Contributor Author

Hm, this is truly unexpected. I can strip the whitespace separately to avoid Jenga, but oof...?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iwahbe iwahbe iwahbe left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@guineveresaenger guineveresaenger

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@guineveresaenger @iwahbe