Skip to content

Add more shim representation tests #2456

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Oct 1, 2024
Merged

Add more shim representation tests #2456

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
850973d
Check generated schema for the SDKv2 shim space
t0yv0 Sep 30, 2024
be4cea3
Refine PF tests
t0yv0 Sep 30, 2024
6ad4e4c
golangci-lint run . --fix
t0yv0 Sep 30, 2024
02ddc5d
Lint fix
t0yv0 Sep 30, 2024
35e0c00
Revert cty.go change
t0yv0 Sep 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Revert cty.go change
  • Loading branch information
@t0yv0
t0yv0 committed Sep 30, 2024

Verified

This commit was signed with the committer’s verified signature.
MidhunSureshR R Midhun Suresh
SSH Key Fingerprint: /ONbGliMzV7GkuJS4k+UyKWebSCC6VzFiH/lMQ19uuc
Verified
Learn about vigilant mode
commit 35e0c00ef7ffb03c018e1488b23a5712b03caf7e
2 changes: 1 addition & 1 deletion pkg/tfshim/sdk-v2/cty.go
View file
Original file line number Diff line number Diff line change
@@ -160,7 +160,7 @@ func recoverScalarCtyValue(dT cty.Type, value interface{}) (cty.Value, error) {
if value > math.MaxInt64 {
return cty.NilVal, fmt.Errorf("cannot convert %d (uint) to a int64: overflow", value)
}

//nolint:gosec
return cty.NumberIntVal(int64(value)), nil
case int64:
return cty.NumberIntVal(value), nil