[PF] Property based Configure tests #2469
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2469 +/- ##
==========================================
- Coverage 61.76% 59.09% -2.67%
==========================================
Files 380 386 +6
Lines 51263 52144 +881
==========================================
- Hits 31665 30817 -848
- Misses 17783 19519 +1736
+ Partials 1815 1808 -7 ☔ View full report in Codecov by Sentry. |
iwahbe
force-pushed
the
iwahbe/property-based-pf-types
branch
11 times, most recently
from
40db0a7
to
a77c9b8
Compare
iwahbe
force-pushed
the
iwahbe/property-based-pf-types
branch
8 times, most recently
from
e757705
to
f4b7096
Compare
iwahbe
force-pushed
the
iwahbe/property-based-pf-types
branch
from
f4b7096
to
974b86e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Property based testing (using
"pgregory.net/rapid") for PF's Configure call.This includes:
pkg/pf/tests/util/property/pf/schema/providerpkg/pf/tests/util/property/pf/value/providerpkg/pf/tests/provider_configure_test.gocrosstests.Configureis strict by default, which we do not pass in the arbitrary case. The implementation inprovider_configure_test.goincludes an equality function that relaxes the assertion so it is passible. Each clause in the relax function is a potential bug that we can address.