-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mark old modules as deprecated #2482
Open
blampe
wants to merge
1
commit into
master
Choose a base branch
from
blampe/deprecate
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change is part of the following stack: Change managed by git-spice. |
This was referenced Oct 11, 2024
Merged
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2482 +/- ##
=======================================
Coverage 61.76% 61.76%
=======================================
Files 380 380
Lines 51263 51263
=======================================
Hits 31665 31665
- Misses 17782 17783 +1
+ Partials 1816 1815 -1 ☔ View full report in Codecov by Sentry. |
blampe
force-pushed
the
blampe/deprecate
branch
2 times, most recently
from
October 15, 2024 17:29
e6a0f38
to
6708429
Compare
blampe
force-pushed
the
blampe/restore
branch
from
October 15, 2024 17:32
30a5e57
to
ca606fb
Compare
blampe
force-pushed
the
blampe/deprecate
branch
from
October 15, 2024 17:32
6708429
to
56efbf4
Compare
blampe
force-pushed
the
blampe/restore
branch
from
October 15, 2024 18:00
ca606fb
to
e21b7d5
Compare
blampe
force-pushed
the
blampe/deprecate
branch
from
October 15, 2024 18:00
56efbf4
to
37b1095
Compare
This should only be merged well after our automated upgrades have pointed downstream providers at the new import paths.
blampe
force-pushed
the
blampe/deprecate
branch
from
October 15, 2024 19:02
37b1095
to
0ff3ed3
Compare
@blampe Can you point me to the automation that will move our providers over to the new module path? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should only be merged well after our automated upgrades have
pointed downstream providers at the new import paths.