Replace "Managed by Terraform" in our docs #2611
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2611 +/- ##
==========================================
- Coverage 62.79% 62.79% -0.01%
==========================================
Files 389 389
Lines 51938 51939 +1
==========================================
- Hits 32615 32613 -2
- Misses 17515 17517 +2
- Partials 1808 1809 +1 ☔ View full report in Codecov by Sentry. |
guineveresaenger
approved these changes
Nov 13, 2024
| @@ -265,6 +265,36 @@ func TestApplyEditRules(t *testing.T) { | |||
| expected: []byte("# Configuration Reference"), | |||
| phase: info.PostCodeTranslation, | |||
| }, | |||
| { | |||
| // Found in azuredevops: https://github.com/pulumi/pulumi-terraform-bridge/issues/2610 | |||
| name: `Replaces "Managed by Terraform" with "Manged by Pulumi"`, | |||
There was a problem hiding this comment.
Suggested change
| name: `Replaces "Managed by Terraform" with "Manged by Pulumi"`, | |
| name: `Replaces "Managed by Terraform" with "Managed by Pulumi"`, |
| `), | ||
| }, | ||
| { | ||
| name: "Does not replace \"Managed by Terraform\" with \"Manged by Pulumi\" (require quotes)", |
There was a problem hiding this comment.
Suggested change
| name: "Does not replace \"Managed by Terraform\" with \"Manged by Pulumi\" (require quotes)", | |
| name: "Does not replace \"Managed by Terraform\" with \"Managed by Pulumi\" without quotes", |
This reads a bit clearer to me. WDYT? Or maybe elaborate in the comment.
| name: "Does not replace \"Managed by Terraform\" with \"Manged by Pulumi\" (require quotes)", | ||
| // It's harder to tell if Managed by Terraform would sense to replace, so we don't do it for now. | ||
| // | ||
| // We don't have a canonical example where this does not work. |
There was a problem hiding this comment.
What does "does not work" mean here?
Perhaps link a followup issue here that considers adding this? Since presumably if we do do so, this test would fail.
| }, | ||
| { | ||
| name: "Does not replace \"Managed by Terraform\" with \"Manged by Pulumi\" (require quotes)", | ||
| // It's harder to tell if Managed by Terraform would sense to replace, so we don't do it for now. |
There was a problem hiding this comment.
Suggested change
| // It's harder to tell if Managed by Terraform would sense to replace, so we don't do it for now. | |
| // It's harder to tell if Managed by Terraform would make sense to replace, so we don't do it for now. |
Merged
guineveresaenger
added a commit
that referenced
this pull request
Nov 14, 2024
Follow-up to #2611, which I didn't realize was set to automerge.
|
This PR has been shipped in release v3.96.0. |
|
@ericrudder AFAIK these were all covered in #2619. I took another look at this PR, and couldn't find any typos still present in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2610