Make pf data source map mutable

[VenelinMartinov]

This change makes the PF datasources map mutable in order to support aliases like we do for resources.

The changes here mimic what we did for resources in #1938

Related to #2585

[VenelinMartinov]

This change is part of the following stack:

• Add datasources to pf providerbuilder #2615
  • Make pf data source map mutable #2616 ◀
    • Support data source aliasing using clone #2617

_{Change managed by git-spice.}

[codecov]

Codecov Report

Attention: Patch coverage is 43.58974% with 22 lines in your changes missing coverage. Please review.

Project coverage is 62.78%. Comparing base (317d4b8) to head (b91cc6e).
Report is 3 commits behind head on master.

Files with missing lines	Patch %	Lines
...f/tests/internal/providerbuilder/build_provider.go	17.64%	12 Missing and 2 partials ⚠️
...tests/internal/providerbuilder/build_datasource.go	0.00%	6 Missing ⚠️
pkg/pf/internal/schemashim/schemashim.go	75.00%	1 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #2616      +/-   ##
==========================================
- Coverage   62.80%   62.78%   -0.02%     
==========================================
  Files         389      390       +1     
  Lines       51939    51953      +14     
==========================================
- Hits        32622    32621       -1     
- Misses      17509    17524      +15     
  Partials     1808     1808              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[iwahbe]

This looks fine as long as we don't cast out of newSchemaOnlyDataSourceMap(...). We are just casting away information.

[VenelinMartinov]

This looks fine as long as we don't cast out of newSchemaOnlyDataSourceMap(...). We are just casting away information.

What do you mean here? Which cast are you referring to?

[iwahbe]

This looks fine as long as we don't cast out of newSchemaOnlyDataSourceMap(...). We are just casting away information.

What do you mean here? Which cast are you referring to?

newSchemaOnlyDataSourceMap discards information going from runtypes.DataSources to shim.ResourceMap. That's what I meant.

[pulumi-bot]

This PR has been shipped in release v3.96.0.