Move unstable/logging to internal/logging
#2687
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since PF is now part of the same module as the rest of the bridge, there is no need for the `unstable` folder, since we can just use `internal`.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2687 +/- ##
=======================================
Coverage 69.44% 69.44%
=======================================
Files 301 301
Lines 38626 38626
=======================================
Hits 26824 26824
Misses 10277 10277
Partials 1525 1525 ☔ View full report in Codecov by Sentry. |
VenelinMartinov
approved these changes
Dec 5, 2024
|
This PR has been shipped in release v3.97.0. |
flostadler
added a commit
to pulumi/pulumi-aws
that referenced
this pull request
Dec 10, 2024
This PR was generated via `$ upgrade-provider pulumi/pulumi-aws --kind=bridge`. --- - Upgrading pulumi-terraform-bridge from v3.96.0 to v3.97.0. **Manual Changes**: Please pay special attention to `provider/pkg/batch/compute_environment.go` and `provider/pkg/batch/compute_environment_test.go`. The test was previously using the `logging` package from the `unstable` module that shouldn't have been used outside of the bridge. This package was recently moved to be internal (pulumi/pulumi-terraform-bridge#2687). To get around that we now pass in the logger as a dependency and fake it in tests. Fixes #4759 Fixes #4894
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since PF is now part of the same module as the rest of the bridge, there is no need for the
unstablefolder, since we can just useinternal.