Fix PF extra config triggering check config errors #2701
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VenelinMartinov
force-pushed
the
vvm/fix_extra_config_checkconfig_error
branch
from
acf464d to
4194212
Compare
VenelinMartinov
changed the title
VenelinMartinov
force-pushed
the
vvm/fix_extra_config_checkconfig_error
branch
from
4194212 to
73e6ad7
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2701 +/- ##
==========================================
+ Coverage 69.47% 69.50% +0.03%
==========================================
Files 301 301
Lines 38644 38646 +2
==========================================
+ Hits 26847 26860 +13
+ Misses 10272 10262 -10
+ Partials 1525 1524 -1 ☔ View full report in Codecov by Sentry. |
iwahbe
reviewed
Dec 10, 2024
t0yv0
approved these changes
Dec 10, 2024
VenelinMartinov
force-pushed
the
vvm/fix_extra_config_checkconfig_error
branch
from
73e6ad7 to
52f77e1
Compare
|
This PR has been shipped in release v3.97.1. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pulumi providers can specify an
ExtraConfigfield for provider configuration which is exclusive to Pulumi and is not passed to the underlying TF provider. This works correctly for the SDKv2 bridge but the PF bridge errors when that config is used.This PR fixes that and adds a test.
fixes #2702