Fix some casing in resource options (#690)

Noticed these warning while running conformance tests. Nothing's testing ignoreChanges yet but it's an obvious fix.
pulumi · Nov 19, 2024 · fcea5fb · fcea5fb
1 parent 61b83d7
commit fcea5fb
Show file tree

Hide file tree

Showing 9 changed files with 18 additions and 12 deletions.
diff --git a/.changes/unreleased/Bug Fixes-690.yaml b/.changes/unreleased/Bug Fixes-690.yaml
@@ -0,0 +1,6 @@
+component: codegen
+kind: Bug Fixes
+body: Fix casing of `dependsOn` and `ignoreChanges` in program generation
+time: 2024-11-19T09:27:55.604415606Z
+custom:
+  PR: "690"
diff --git a/cmd/pulumi-language-yaml/testdata/projects/l2-failed-create-continue-on-error/Main.yaml b/cmd/pulumi-language-yaml/testdata/projects/l2-failed-create-continue-on-error/Main.yaml
@@ -8,7 +8,7 @@ resources:
     properties:
       value: true
     options:
-      dependson:
+      dependsOn:
         - ${failing}
   dependent_on_output:
     type: simple:Resource
@@ -23,6 +23,6 @@ resources:
     properties:
       value: true
     options:
-      dependson:
+      dependsOn:
         - ${independent}
         - ${dependent_on_output}
diff --git a/cmd/pulumi-language-yaml/testdata/projects/l2-target-up-with-new-dependency/1/Main.yaml b/cmd/pulumi-language-yaml/testdata/projects/l2-target-up-with-new-dependency/1/Main.yaml
@@ -8,7 +8,7 @@ resources:
     properties:
       value: true
     options:
-      dependson:
+      dependsOn:
         - ${dep}
   dep:
     type: simple:Resource

diff --git a/pkg/pulumiyaml/codegen/gen_program.go b/pkg/pulumiyaml/codegen/gen_program.go
@@ -213,7 +213,7 @@ func (g *generator) genResourceOpts(opts *pcl.ResourceOptions) *syn.ObjectNode {
 		elems := g.expr(opts.DependsOn)
 		_, ok := elems.(*syn.ListNode)
 		contract.Assertf(ok, "Expected a list node, got %T", elems)
-		rOpts = append(rOpts, syn.ObjectProperty(syn.String("dependson"), elems))
+		rOpts = append(rOpts, syn.ObjectProperty(syn.String("dependsOn"), elems))
 	}
 	if opts.IgnoreChanges != nil {
 		elems := g.expr(opts.IgnoreChanges).(*syn.ListNode)
@@ -222,7 +222,7 @@ func (g *generator) genResourceOpts(opts *pcl.ResourceOptions) *syn.ObjectNode {
 			ignoreChanges[i] = unquoteInterpolation(elems.Index(i))
 		}
 		list := syn.ListSyntax(elems.Syntax(), ignoreChanges...)
-		rOpts = append(rOpts, syn.ObjectProperty(syn.String("ignorechanges"), list))
+		rOpts = append(rOpts, syn.ObjectProperty(syn.String("ignoreChanges"), list))
 	}
 	if opts.Protect != nil {
 		expr := mustCoerceBoolean(g.expr(opts.Protect))

diff --git a/...ting/test/testdata/aws-fargate-output-versioned-pp/yaml/aws-fargate-output-versioned.yaml b/...ting/test/testdata/aws-fargate-output-versioned-pp/yaml/aws-fargate-output-versioned.yaml
@@ -95,7 +95,7 @@ resources:
           containerName: my-app
           containerPort: 80
     options:
-      dependson:
+      dependsOn:
         - ${webListener}
 variables:
   # Read the default VPC and public subnets, which we will use.

diff --git a/pkg/pulumiyaml/testing/test/testdata/aws-fargate-pp/yaml/aws-fargate.yaml b/pkg/pulumiyaml/testing/test/testdata/aws-fargate-pp/yaml/aws-fargate.yaml
@@ -95,7 +95,7 @@ resources:
           containerName: my-app
           containerPort: 80
     options:
-      dependson:
+      dependsOn:
         - ${webListener}
 variables:
   # Read the default VPC and public subnets, which we will use.

diff --git a/...-resource-options-multiple-providers.pp/yaml/aws-resource-options-multiple-providers.yaml b/...-resource-options-multiple-providers.pp/yaml/aws-resource-options-multiple-providers.yaml
@@ -11,9 +11,9 @@ resources:
     type: aws:s3:Bucket
     options:
       provider: ${provider}
-      dependson:
+      dependsOn:
         - ${provider}
-      ignorechanges:
+      ignoreChanges:
         - bucket
         - lifecycleRules[0]
       protect: true

diff --git a/pkg/pulumiyaml/testing/test/testdata/aws-resource-options-pp/yaml/aws-resource-options.yaml b/pkg/pulumiyaml/testing/test/testdata/aws-resource-options-pp/yaml/aws-resource-options.yaml
@@ -7,9 +7,9 @@ resources:
     type: aws:s3:Bucket
     options:
       provider: ${provider}
-      dependson:
+      dependsOn:
         - ${provider}
-      ignorechanges:
+      ignoreChanges:
         - bucket
         - lifecycleRules[0]
       protect: true
diff --git a/pkg/pulumiyaml/testing/test/testdata/depends-on-array-pp/yaml/depends-on-array.yaml b/pkg/pulumiyaml/testing/test/testdata/depends-on-array-pp/yaml/depends-on-array.yaml
@@ -25,7 +25,7 @@ resources:
       contentType: text/html
       acl: public-read
     options:
-      dependson:
+      dependsOn:
         - ${publicAccessBlock}
         - ${ownershipControls}
 outputs: