include name from original project if the compiler doesn't return it #610
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lunaris
approved these changes
Aug 9, 2024
tgummerer
force-pushed
the
tg/better-error-on-compiler-incompleteness
branch
2 times, most recently
from
e6375ac
to
3863ced
Compare
tgummerer
changed the title
tgummerer
changed the title
lunaris
approved these changes
Aug 9, 2024
tgummerer
force-pushed
the
tg/better-error-on-compiler-incompleteness
branch
from
3863ced
to
16b896e
Compare
The pulumi-yaml runtime expects the compiler to return a complete yaml project, including the `name` attribute. The compiler might not return this however, even when it returns a valid yaml program otherwise. This leads to issues down the line, as the rest of the runtime expects the name to be set in the template, and might panic if it isn't. We do however have the name from the original Pulumi.yaml, so we can fill that in for the user, even if the compiler doesn't return it in the template.
tgummerer
force-pushed
the
tg/better-error-on-compiler-incompleteness
branch
from
16b896e
to
c921f64
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The pulumi-yaml runtime expects the compiler to return a complete yaml project, including the
nameattribute. The compiler might not return this however, even when it returns a valid yaml program otherwise.This leads to issues down the line, as the rest of the runtime expects the name to be set in the template, and might panic if it isn't. We do however have the name from the original Pulumi.yaml, so we can fill that in for the user, even if the compiler doesn't return it in the template.
Fixes #609