Allow missing nodes in template #617
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julienp
force-pushed
the
julienp/required-plugins
branch
from
ac1b051
to
c9261f6
Compare
When a node can not be found, add a missingNode as a placeholder. When walking the graph, VisitMissing can customize the behaviour for these nodes. For typechecking and program evaluation missing nodes are always an error. During `GetRequiredPlugins` we do not have the program's config available to us. Previously we would abort the graph walk as soon as we hit a missing configuration reference. With this PR, we ignore missing nodes and continue the walk. This allows us detect plugins configured on resources.
julienp
force-pushed
the
julienp/required-plugins
branch
from
c9261f6
to
2d85f1f
Compare
tgummerer
approved these changes
Aug 27, 2024
|
This PR has been shipped in release v1.10.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a node can not be found, add a missingNode as a placeholder. When walking the graph, VisitMissing can be used to customize the behaviour for these nodes. For typechecking and program evaluation missing nodes are always an error.
During
GetRequiredPluginswe do not have the program's config available to us. Previously we would abort the graph walk as soon as we hit a missing configuration reference. With this PR, we ignore missing nodes and continue the walk. This allows us detect plugin configuration on resources.This approach is partially inspired by previous work allowing incomplete templates #393.
Fixes #603