Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test and fix support for local plugins #619

Merged
merged 1 commit into from
Sep 3, 2024
Merged

Conversation

Frassle
Copy link
Member

@Frassle Frassle commented Aug 29, 2024

This updates the pulumi dependency to d9df4771815894ab6ddaf17b78f6f023c91b7148 which has a number of fixes for plugin and schema loading.

This allows YAML to correctly load schemas for plugins defined in the Pulumi.yaml file itself. We often use this for integration tests, but we expect users to increasingly make use of this feature in the future as an alternative to dynamic providers.

@Frassle Frassle force-pushed the fraser/localPlugins branch 3 times, most recently from d7d176a to 135f81e Compare August 31, 2024 14:45
@Frassle Frassle changed the title Support local plugins Test and fix support for local plugins Aug 31, 2024
This updates the pulumi dependency to
[d9df4771815894ab6ddaf17b78f6f023c91b7148](pulumi/pulumi@d9df477)
which has a number of fixes for plugin and schema loading.

This allows YAML to correctly load schemas for plugins defined in the
Pulumi.yaml file itself. We often use this for integegration tests, but we
expect users to increasinly make use of this feature in the future as an
alternative to dynamic providers.
@Frassle Frassle marked this pull request as ready for review August 31, 2024 14:47
@Frassle Frassle requested a review from a team as a code owner August 31, 2024 14:47
@@ -0,0 +1,10 @@
name: local
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should test provider be listed as a plugin here? Does program test add the plugins to the project for us?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeh program test adds it for us. We can't add it directly here because program test also copies the test code to a temp dir so a plain relative path doesn't work.

@@ -0,0 +1,101 @@
// Copyright 2016-2021, Pulumi Corporation.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit, I think these are copied from pu/pu, since the provider needs to be available at a relative path. Not sure if we need to update the copyright dates here and in the other files.

Suggested change
// Copyright 2016-2021, Pulumi Corporation.
// Copyright 2024, Pulumi Corporation.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They are directly copied, just as the fastest way to get something to test this with.
Ideally yaml wouldn't do it's own plugin loading and then we wouldn't need this test, so I'm hoping we can rm all this again at some point.
I don't think the copyright needs updating, the content is the same.

@Frassle Frassle merged commit ef1fb05 into main Sep 3, 2024
5 checks passed
@Frassle Frassle deleted the fraser/localPlugins branch September 3, 2024 08:40
@pulumi-bot
Copy link

This PR has been shipped in release v1.10.0.

@pulumi-bot
Copy link

This PR has been shipped in release v1.10.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants