return correct element types for latebound resources #664
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We currently return a pointer to the interface for latebound resources from their ElementType methods. However pulumi expects pointers to the concrete type here, so it can create it and assign values to the created object. Fix that.
julienp
approved these changes
Oct 14, 2024
|
This PR has been shipped in release v1.11.2. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We currently return a pointer to the interface for latebound resources from their ElementType methods. However pulumi expects pointers to the concrete type here, so it can create it and assign values to the created object. Fix that.
In particular this can happen when calling
fn::secreton a created resource. Currently that will panic because the internals get confused by this wrongElementType. I'm not sure it makes all that much sense to even callfn::secreton this, but we shouldn't panic either.Fixes pulumi/pulumi#17530. I'm not sure this completely fixes it as I've managed to produce a slightly different panic, but not the same one. For lack of better ideas I'm gonna claim this fixes it for now, and we can revisit if we get any more panic reports with a pulumi version with this fix included.