Enable l2-resource-simple #676
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Frassle
force-pushed
the
fraser/l2-simple
branch
from
899ba63
to
a5563a1
Compare
Frassle
force-pushed
the
fraser/l2-simple
branch
from
a5563a1
to
2404a8f
Compare
Frassle
force-pushed
the
fraser/l2-simple
branch
from
2404a8f
to
7eb01d6
Compare
Zaid-Ajaj
approved these changes
Nov 15, 2024
|
This PR has been shipped in release v1.12.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables the l2-resource-simple test.
This required a few fixes.
Firstly in
GetReferencedPluginswe look at any package declarations to get package versions. This is so we can return the plugin info with the right version.Secondly we add
GetReferencePackagesmethod to use fromGetProgramDependenciesso that we can actually return something fromGetProgramDependenciesrather than nothing. Conformance testing tests this so we have to fill it in.Thirdly we implement
Pack, it doesn't do much just copies the generated package declaration yaml file.