Fix slice bounds out of range panic in fixupPath #16575

mlafeldt · 2024-07-03T12:47:25Z

I noticed that sst currently panics if an environment variable's name is shorter than 5 characters. This fixes the root cause.

V=1 sst deploy --stage=dev 
SST ❍ ion 0.0.416  ready!

➜  App:        myapp
   Stage:      dev

~  Deploying

panic: runtime error: slice bounds out of range [:5] with length 3

goroutine 1 [running]:
github.com/pulumi/pulumi/sdk/v3/go/auto.fixupPath({0x140018ec408, 0xb1, 0x1400013dfc0?}, {0x1400013dfc0, 0x32})
        /home/runner/go/pkg/mod/github.com/pulumi/pulumi/sdk/v3@v3.115.2/go/auto/cmd.go:324 +0x270
github.com/pulumi/pulumi/sdk/v3/go/auto.pulumiCommand.Run({{0x3, 0x73, 0x2, {0x0, 0x0, 0x0}, {0x0, 0x0, 0x0}}, {0x1400013dfc0, ...}}, ...)
        /home/runner/go/pkg/mod/github.com/pulumi/pulumi/sdk/v3@v3.115.2/go/auto/cmd.go:273 +0x394
github.com/pulumi/pulumi/sdk/v3/go/auto.(*LocalWorkspace).runPulumiInputCmdSync(0x14001494000, {0x106fb2b28, 0x1400061c0f0}, {0x0, 0x0}, {0x14000aeba00, 0x4, 0x4})
        /home/runner/go/pkg/mod/github.com/pulumi/pulumi/sdk/v3@v3.115.2/go/auto/local_workspace.go:776 +0x1f4
github.com/pulumi/pulumi/sdk/v3/go/auto.(*LocalWorkspace).runPulumiCmdSync(...)
        /home/runner/go/pkg/mod/github.com/pulumi/pulumi/sdk/v3@v3.115.2/go/auto/local_workspace.go:790
github.com/pulumi/pulumi/sdk/v3/go/auto.(*LocalWorkspace).SelectStack(0x14001494000, {0x106fb2b28, 0x1400061c0f0}, {0x16b392623, 0x3})
        /home/runner/go/pkg/mod/github.com/pulumi/pulumi/sdk/v3@v3.115.2/go/auto/local_workspace.go:568 +0x160
github.com/pulumi/pulumi/sdk/v3/go/auto.SelectStack({0x106fb2b28?, 0x1400061c0f0?}, {0x16b392623, 0x3}, {0x106fcd6e0, 0x14001494000})
        /home/runner/go/pkg/mod/github.com/pulumi/pulumi/sdk/v3@v3.115.2/go/auto/stack.go:179 +0x5c
github.com/pulumi/pulumi/sdk/v3/go/auto.UpsertStack({0x106fb2b28, 0x1400061c0f0}, {0x16b392623, 0x3}, {0x106fcd6e0, 0x14001494000})
        /home/runner/go/pkg/mod/github.com/pulumi/pulumi/sdk/v3@v3.115.2/go/auto/stack.go:191 +0x34
github.com/sst/ion/pkg/project.(*stack).Run(0x14000a42058, {0x106fb2b28, 0x1400061c0f0}, 0x140000bbcc0)
        /home/runner/work/ion/ion/pkg/project/stack.go:283 +0x1cf4
main.init.func3(0x14000064550)
        /home/runner/work/ion/ion/cmd/sst/main.go:458 +0x2c8
main.run()
        /home/runner/work/ion/ion/cmd/sst/main.go:160 +0x6cc
main.main()
        /home/runner/work/ion/ion/cmd/sst/main.go:52 +0x12c

github-actions · 2024-07-03T12:52:35Z

PR is now waiting for a maintainer to take action.

Note for the maintainer: Commands available:

/run-acceptance-tests - used to test run the acceptance tests for the project
/run-codegen - used to test the Pull Request against downstream codegen
/run-docs-gen - used to test the Pull Request against documentation generation

pulumi-bot · 2024-07-03T12:52:59Z

Changelog

[uncommitted] (2024-07-08)

Bug Fixes

[sdk/go] Fix out-of-range panic when sanitizing PATH env var

tgummerer

Thanks, this looks obviously correct!

Would you be willing to add a changelog entry (using make changelog), and a test in sdk/go/auto/cmd_test.go? Then we can get this merged.

tgummerer · 2024-07-03T12:58:41Z

/run-acceptance-tests

mlafeldt · 2024-07-03T13:20:51Z

Thanks, this looks obviously correct!

Would you be willing to add a changelog entry (using make changelog), and a test in sdk/go/auto/cmd_test.go? Then we can get this merged.

Sure, just made the changes.

github-actions · 2024-07-03T13:54:41Z

PR is now waiting for a maintainer to take action.

Note for the maintainer: Commands available:

/run-acceptance-tests - used to test run the acceptance tests for the project
/run-codegen - used to test the Pull Request against downstream codegen
/run-docs-gen - used to test the Pull Request against documentation generation

github-actions · 2024-07-03T13:55:54Z

PR is now waiting for a maintainer to take action.

Note for the maintainer: Commands available:

/run-acceptance-tests - used to test run the acceptance tests for the project
/run-codegen - used to test the Pull Request against downstream codegen
/run-docs-gen - used to test the Pull Request against documentation generation

github-actions · 2024-07-03T13:56:35Z

PR is now waiting for a maintainer to take action.

Note for the maintainer: Commands available:

/run-acceptance-tests - used to test run the acceptance tests for the project
/run-codegen - used to test the Pull Request against downstream codegen
/run-docs-gen - used to test the Pull Request against documentation generation

github-actions · 2024-07-08T09:00:12Z

PR is now waiting for a maintainer to take action.

Note for the maintainer: Commands available:

/run-acceptance-tests - used to test run the acceptance tests for the project
/run-codegen - used to test the Pull Request against downstream codegen
/run-docs-gen - used to test the Pull Request against documentation generation

Tentative changelog: ### Features - [docs] Add ability to constrain supported languages of resource and function overlays - [engine] Guess references to properties 'name' and 'arn' between dependant resources during import [#16234](#16234) - [sdk/nodejs] Add `dependsOn` to `InvokeOptions` in the NodeJS SDK [#16560](#16560) ### Bug Fixes - [cli/new] Use default values for language specific prompts when using --yes [#16595](#16595) - [docs] Fix generating constructor syntax examples for kubernetes [#16574](#16574) - [docs] Fix generating constructor syntax examples in Go for package awsx [#16583](#16583) - [backend/service] Retry POST requests that time out during handshake timeouts [#16576](#16576) - [engine] Avoid computing refresh `Diff`s for external resources [#16544](#16544) - [engine] Fix program hanging when the import resource option is used and the inputs don't match [#16572](#16572) - [programgen/go] Do not emit index module for resources without a schema [#16588](#16588) - [sdk/go] Fix out-of-range panic when sanitizing PATH env var [#16575](#16575) - [sdk/nodejs] Fix creating a closure with object getters and setters [#16568](#16568) - [programgen/python] Fix Python program generation for remote assets [#16556](#16556) ### Miscellaneous - [sdk/nodejs] Bump `@opentelemetry` packages in the NodeJS SDK [#16558](#16558)

Stacked PR on top of #16607 Tentative changelog: ### Features - [docs] Add ability to constrain supported languages of resource and function overlays - [engine] Guess references to properties 'name' and 'arn' between dependant resources during import [#16234](#16234) - [sdk/nodejs] Add `dependsOn` to `InvokeOptions` in the NodeJS SDK [#16560](#16560) ### Bug Fixes - [cli/new] Use default values for language specific prompts when using --yes [#16595](#16595) - [docs] Fix generating constructor syntax examples for kubernetes [#16574](#16574) - [docs] Fix generating constructor syntax examples in Go for package awsx [#16583](#16583) - [backend/service] Retry POST requests that time out during handshake timeouts [#16576](#16576) - [engine] Avoid computing refresh `Diff`s for external resources [#16544](#16544) - [engine] Fix program hanging when the import resource option is used and the inputs don't match [#16572](#16572) - [programgen/go] Do not emit index module for resources without a schema [#16588](#16588) - [sdk/go] Fix out-of-range panic when sanitizing PATH env var [#16575](#16575) - [sdk/nodejs] Fix creating a closure with object getters and setters [#16568](#16568) - [programgen/python] Fix Python program generation for remote assets [#16556](#16556) ### Miscellaneous - [sdk/nodejs] Bump `@opentelemetry` packages in the NodeJS SDK [#16558](#16558)

pulumi-bot · 2024-07-10T22:23:11Z

This PR has been shipped in release v3.123.0.

pulumi-bot · 2024-07-10T22:23:11Z

This PR has been shipped in release v3.123.0.

I noticed that sst currently panics if an environment variable's name is shorter than 5 characters. This fixes the root cause. ``` V=1 sst deploy --stage=dev SST ❍ ion 0.0.416 ready! ➜ App: myapp Stage: dev ~ Deploying panic: runtime error: slice bounds out of range [:5] with length 3 goroutine 1 [running]: github.com/pulumi/pulumi/sdk/v3/go/auto.fixupPath({0x140018ec408, 0xb1, 0x1400013dfc0?}, {0x1400013dfc0, 0x32}) /home/runner/go/pkg/mod/github.com/pulumi/pulumi/sdk/v3@v3.115.2/go/auto/cmd.go:324 +0x270 github.com/pulumi/pulumi/sdk/v3/go/auto.pulumiCommand.Run({{0x3, 0x73, 0x2, {0x0, 0x0, 0x0}, {0x0, 0x0, 0x0}}, {0x1400013dfc0, ...}}, ...) /home/runner/go/pkg/mod/github.com/pulumi/pulumi/sdk/v3@v3.115.2/go/auto/cmd.go:273 +0x394 github.com/pulumi/pulumi/sdk/v3/go/auto.(*LocalWorkspace).runPulumiInputCmdSync(0x14001494000, {0x106fb2b28, 0x1400061c0f0}, {0x0, 0x0}, {0x14000aeba00, 0x4, 0x4}) /home/runner/go/pkg/mod/github.com/pulumi/pulumi/sdk/v3@v3.115.2/go/auto/local_workspace.go:776 +0x1f4 github.com/pulumi/pulumi/sdk/v3/go/auto.(*LocalWorkspace).runPulumiCmdSync(...) /home/runner/go/pkg/mod/github.com/pulumi/pulumi/sdk/v3@v3.115.2/go/auto/local_workspace.go:790 github.com/pulumi/pulumi/sdk/v3/go/auto.(*LocalWorkspace).SelectStack(0x14001494000, {0x106fb2b28, 0x1400061c0f0}, {0x16b392623, 0x3}) /home/runner/go/pkg/mod/github.com/pulumi/pulumi/sdk/v3@v3.115.2/go/auto/local_workspace.go:568 +0x160 github.com/pulumi/pulumi/sdk/v3/go/auto.SelectStack({0x106fb2b28?, 0x1400061c0f0?}, {0x16b392623, 0x3}, {0x106fcd6e0, 0x14001494000}) /home/runner/go/pkg/mod/github.com/pulumi/pulumi/sdk/v3@v3.115.2/go/auto/stack.go:179 +0x5c github.com/pulumi/pulumi/sdk/v3/go/auto.UpsertStack({0x106fb2b28, 0x1400061c0f0}, {0x16b392623, 0x3}, {0x106fcd6e0, 0x14001494000}) /home/runner/go/pkg/mod/github.com/pulumi/pulumi/sdk/v3@v3.115.2/go/auto/stack.go:191 +0x34 github.com/sst/ion/pkg/project.(*stack).Run(0x14000a42058, {0x106fb2b28, 0x1400061c0f0}, 0x140000bbcc0) /home/runner/work/ion/ion/pkg/project/stack.go:283 +0x1cf4 main.init.func3(0x14000064550) /home/runner/work/ion/ion/cmd/sst/main.go:458 +0x2c8 main.run() /home/runner/work/ion/ion/cmd/sst/main.go:160 +0x6cc main.main() /home/runner/work/ion/ion/cmd/sst/main.go:52 +0x12c ```

Tentative changelog: ### Features - [docs] Add ability to constrain supported languages of resource and function overlays - [engine] Guess references to properties 'name' and 'arn' between dependant resources during import [#16234](#16234) - [sdk/nodejs] Add `dependsOn` to `InvokeOptions` in the NodeJS SDK [#16560](#16560) ### Bug Fixes - [cli/new] Use default values for language specific prompts when using --yes [#16595](#16595) - [docs] Fix generating constructor syntax examples for kubernetes [#16574](#16574) - [docs] Fix generating constructor syntax examples in Go for package awsx [#16583](#16583) - [backend/service] Retry POST requests that time out during handshake timeouts [#16576](#16576) - [engine] Avoid computing refresh `Diff`s for external resources [#16544](#16544) - [engine] Fix program hanging when the import resource option is used and the inputs don't match [#16572](#16572) - [programgen/go] Do not emit index module for resources without a schema [#16588](#16588) - [sdk/go] Fix out-of-range panic when sanitizing PATH env var [#16575](#16575) - [sdk/nodejs] Fix creating a closure with object getters and setters [#16568](#16568) - [programgen/python] Fix Python program generation for remote assets [#16556](#16556) ### Miscellaneous - [sdk/nodejs] Bump `@opentelemetry` packages in the NodeJS SDK [#16558](#16558)

Stacked PR on top of #16607 Tentative changelog: ### Features - [docs] Add ability to constrain supported languages of resource and function overlays - [engine] Guess references to properties 'name' and 'arn' between dependant resources during import [#16234](#16234) - [sdk/nodejs] Add `dependsOn` to `InvokeOptions` in the NodeJS SDK [#16560](#16560) ### Bug Fixes - [cli/new] Use default values for language specific prompts when using --yes [#16595](#16595) - [docs] Fix generating constructor syntax examples for kubernetes [#16574](#16574) - [docs] Fix generating constructor syntax examples in Go for package awsx [#16583](#16583) - [backend/service] Retry POST requests that time out during handshake timeouts [#16576](#16576) - [engine] Avoid computing refresh `Diff`s for external resources [#16544](#16544) - [engine] Fix program hanging when the import resource option is used and the inputs don't match [#16572](#16572) - [programgen/go] Do not emit index module for resources without a schema [#16588](#16588) - [sdk/go] Fix out-of-range panic when sanitizing PATH env var [#16575](#16575) - [sdk/nodejs] Fix creating a closure with object getters and setters [#16568](#16568) - [programgen/python] Fix Python program generation for remote assets [#16556](#16556) ### Miscellaneous - [sdk/nodejs] Bump `@opentelemetry` packages in the NodeJS SDK [#16558](#16558)

Fix slice bounds out of range panic in fixupPath

c8e25d2

mlafeldt requested a review from a team as a code owner July 3, 2024 12:47

tgummerer approved these changes Jul 3, 2024

View reviewed changes

mlafeldt added 2 commits July 3, 2024 15:14

Add changelog entry

b8597ab

Add test case

9e521a3

mlafeldt force-pushed the patch-2 branch from 8117a2a to 9e521a3 Compare July 3, 2024 13:19

Tweak description

b6b8313

Frassle approved these changes Jul 3, 2024

View reviewed changes

Frassle enabled auto-merge July 3, 2024 13:22

lunaris closed this Jul 8, 2024

auto-merge was automatically disabled July 8, 2024 08:59
Pull request was closed

lunaris reopened this Jul 8, 2024

lunaris added this pull request to the merge queue Jul 8, 2024

Merged via the queue into pulumi:master with commit bbf5b0d Jul 8, 2024
14 of 17 checks passed

This was referenced Jul 10, 2024

Prepare for v3.123.0 release #16607

Merged

Freeze v3.123.0 #16608

Merged

mlafeldt mentioned this pull request Jul 15, 2024

Update Pulumi to v3.126.0 sst/ion#675

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix slice bounds out of range panic in fixupPath #16575

Fix slice bounds out of range panic in fixupPath #16575

mlafeldt commented Jul 3, 2024

github-actions bot commented Jul 3, 2024

pulumi-bot commented Jul 3, 2024 •

edited

Loading

tgummerer left a comment

tgummerer commented Jul 3, 2024

mlafeldt commented Jul 3, 2024

github-actions bot commented Jul 3, 2024

github-actions bot commented Jul 3, 2024

github-actions bot commented Jul 3, 2024

github-actions bot commented Jul 8, 2024

pulumi-bot commented Jul 10, 2024

pulumi-bot commented Jul 10, 2024

Fix slice bounds out of range panic in fixupPath #16575

Fix slice bounds out of range panic in fixupPath #16575

Conversation

mlafeldt commented Jul 3, 2024

github-actions bot commented Jul 3, 2024

pulumi-bot commented Jul 3, 2024 • edited Loading

Changelog

[uncommitted] (2024-07-08)

Bug Fixes

tgummerer left a comment

Choose a reason for hiding this comment

tgummerer commented Jul 3, 2024

mlafeldt commented Jul 3, 2024

github-actions bot commented Jul 3, 2024

github-actions bot commented Jul 3, 2024

github-actions bot commented Jul 3, 2024

github-actions bot commented Jul 8, 2024

pulumi-bot commented Jul 10, 2024

pulumi-bot commented Jul 10, 2024

pulumi-bot commented Jul 3, 2024 •

edited

Loading