Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the pulumi new --stack option #3131

Merged
merged 3 commits into from
Sep 11, 2019
Merged

Fix the pulumi new --stack option #3131

merged 3 commits into from
Sep 11, 2019

Conversation

mikhailshilkov
Copy link
Member

Resolves #2880 as per #2880 (comment)

cmd/new.go Show resolved Hide resolved
@mikhailshilkov
Copy link
Member Author

@justinvp So I restored the deleted code block and instead added a check which would only try to lookup an existing stack for a fully qualified stack name org/proj/name. This should keep it backwards compatible and eliminate the errors for other scenarios. At least, the tests are green. Let me know if you see further problems with this approach.

Copy link
Member

@justinvp justinvp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks, Mikhail!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

--stack option broken in pulumi CLI
3 participants