Support using short names for config keys #422
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, you had to fully qualify configuration values (e.g example:config:message). As a convience, let's support adding configuration values where the key is not a fully qualified module member. In this case, we'll treat the key as if `<program-name>:config:` had been prepended to it. In addition, when we print config, shorten keys of the form `<program-name>:config:<key-name>` to `<key-name>`. I've updated one integration test to use the new syntax and left the other as is to ensure both continue to work.
joeduffy
approved these changes
Oct 18, 2017
| return tokens.ParseModuleMember(key) | ||
| } | ||
|
|
||
| func prettyKey(key string) string { |
There was a problem hiding this comment.
Probably worth a handful of little unit tests.
| return "", err | ||
| } | ||
|
|
||
| return tokens.ParseModuleMember(fmt.Sprintf("%s:config:%s", pkg.Name, key)) |
There was a problem hiding this comment.
We decided to nix the config: part, right? Is that planned for a later change?
| @@ -99,3 +102,40 @@ func displayEvents(events <-chan engine.Event, done chan bool, debug bool) { | |||
| } | |||
| } | |||
| } | |||
|
|
|||
| func getPackage() (string, pack.Package, error) { | |||
There was a problem hiding this comment.
If we are keeping workspace, might make sense to have in there as a general helper utility.
There was a problem hiding this comment.
Sure, I do that in a follow up PR.
ellismg
force-pushed
the
pulumi-shorter-config-on-cli
branch
2 times, most recently
from
b639e8c
to
6d01146
Compare
ellismg
force-pushed
the
pulumi-shorter-config-on-cli
branch
from
6d01146
to
c8897d0
Compare
bors bot
added a commit
that referenced
this pull request
Dec 7, 2022
11570: testing: Allow plugin testing users to define their own plugin sets r=AaronFriel a=AaronFriel Updating Pulumi YAML to address pulumi/pulumi-yaml#421 and pulumi/pulumi-yaml#422, requires testing against the Docker v4.0.0-alpha.0 schema. That required updating this repo, and using Go workspaces/module replacement to allow the deploytest plugin loader to find the prerelease schema. This change allows Pulumi YAML to define its own set of required plugins, decoupling the two repos and preventing the catch-22 here. Because this repo will need to support the new example being authored which will serve as a test of #421 and #422, this also adds Docker v4.0.0-alpha.0 as a schema. Co-authored-by: Aaron Friel <mayreply@aaronfriel.com>
bors bot
added a commit
that referenced
this pull request
Dec 7, 2022
11570: testing: Allow plugin testing users to define their own plugin sets r=AaronFriel a=AaronFriel Updating Pulumi YAML to address pulumi/pulumi-yaml#421 and pulumi/pulumi-yaml#422, requires testing against the Docker v4.0.0-alpha.0 schema. That required updating this repo, and using Go workspaces/module replacement to allow the deploytest plugin loader to find the prerelease schema. This change allows Pulumi YAML to define its own set of required plugins, decoupling the two repos and preventing the catch-22 here. Because this repo will need to support the new example being authored which will serve as a test of #421 and #422, this also adds Docker v4.0.0-alpha.0 as a schema. Co-authored-by: Aaron Friel <mayreply@aaronfriel.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, you had to fully qualify configuration values (e.g
example:config:message). As a convience, let's support adding
configuration values where the key is not a fully qualified module
member. In this case, we'll treat the key as if
<program-name>:config:had been prepended to it.In addition, when we print config, shorten keys of the form
<program-name>:config:<key-name>to<key-name>.I've updated one integration test to use the new syntax and left the
other as is to ensure both continue to work.