fix: support tags with build info #65
Conversation
When briding a Terraform provider, it makes a lot of sense to match the Terraform provider version in the Pulumi provider. However, there needs to be a clean way to increment this build while keeping the Terraform version static, without abusing prerelease tags. This is supported by build metadata: https://semver.org/spec/v2.0.0.html
|
@jaxxstorm Any chance you could take a look at this, please? |
iwahbe
requested review from
iwahbe and
guineveresaenger
and removed request for
iwahbe
There was a problem hiding this comment.
I'd like to see additional tests for longer formats to ensure we're appending everything correctly every time.
To clarify the purpose of adding this enhancement: we want to be able to read and support build tags set on patch versions?
Overall, this is a reasonable enhancement. 👍
| @@ -130,12 +132,23 @@ func GetLanguageVersionsWithOptions(opts LanguageVersionsOptions) (*LanguageVers | |||
| preVersion = fmt.Sprintf("%s%sdirty", preVersion, separator) | |||
| } | |||
|
|
|||
| buildVersion := []byte{} | |||
| if len(genericVersion.Build) > 0 { | |||
There was a problem hiding this comment.
What happens if the genericVersion is a prerelease? I see the tests pass, but what is keeping this from adding two build tags to a prerelease? we do add a build tag extension to the preVersion here.
There was a problem hiding this comment.
@guineveresaenger This is just weird behaviour in this code and I dare not add a test for that or touch it, because pulumictl shouldn't be adding the commit hash to prerelease tags.
|
@guineveresaenger New test case added |
| require.NoError(t, err) | ||
|
|
||
| tagSequence := []string{ | ||
| "v1.0.0+1abc.345.whoop", |
|
@guineveresaenger Can we sneak in a release? 😄 |
|
Thanks @guineveresaenger Just seen you cut one. Not sure why it's not shown on the main repo page |
When briding a Terraform provider, it makes
a lot of sense to match the Terraform provider
version in the Pulumi provider.
However, there needs to be a clean way to increment this build while keeping the Terraform version static, without abusing prerelease tags.
This is supported by build metadata:
https://semver.org/spec/v2.0.0.html