Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add datarobot community provider #5345

Merged
merged 1 commit into from
Sep 24, 2024
Merged

Conversation

NolanJMcCafferty
Copy link
Contributor

@NolanJMcCafferty NolanJMcCafferty commented Sep 5, 2024

Description

Add DataRobot provider

Adding a new package?

If this pull request adds a new package:

  • The package's schema URL in this PR is correct.
  • The package metadata file, if present, contains:
    • a supported category (one of Cloud, Infrastructure, Network, Database, Monitoring, or Utility).
    • a valid plugin download URL. See Publish Your Package.
    • a description that explains what the package does.
    • a valid logo URL that points to a PNG whose dimensions conform to the others in this repo (e.g., 100x100).
  • The package repo contains an Overview doc (/docs/_index.md) that includes:
    • a brief explanation of what the package is and what it does.
    • at least one representative example in all supported languages.
    • a front-matter property for the layout set to package.
  • The package repo contains an Installation and Configuration doc (/docs/installation-configuration.md) that includes:
    • links to SDKs in all supported languages.
    • a copyable command for installing the resource plugin if necessary.
    • an example of configuring the provider with pulumi config set.
    • an example of configuring the provider with environment variables.
  • The repository has:
    • a version tag prefixed with v that corresponds with a valid GitHub release and published package SDKs
  • A CODEOWNER has reviewed the PR.
  • A member of the @pulumi/docs team has reviewed all documentation.

Signed-off-by: Nolan McCafferty <nolanm@omnistrate.com>
@jkodroff
Copy link
Member

@NolanJMcCafferty A couple issues I've noted:

  1. There's no .NET SDK: https://github.com/datarobot-community/pulumi-datarobot/blob/main/docs/installation-configuration.md
  2. The link to the Go SDK (from the installation and configuration page linked above) is broken (not sure if this is expected or not): https://pkg.go.dev/github.com/datarobot-community/pulumi-datarobot/sdk
  3. You should add links to SDKs here (but it's not the most common path for Pulumi users to install provider SDKs): https://github.com/datarobot-community/pulumi-datarobot/blob/main/README.md
  4. The TS example has YAML as its language: https://github.com/datarobot-community/pulumi-datarobot/blob/main/docs/_index.md

@NolanJMcCafferty
Copy link
Contributor Author

NolanJMcCafferty commented Sep 20, 2024

Thank you for the comments. I have fixed the SDK and documentation issues.

Copy link
Member

@ringods ringods left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@NolanJMcCafferty there seems to be some mismatch to the chooser/choosable tags in docs/_index.md. Like HTML, the closing tags should match the opening tags.

For instance, these closing tags do not match up with any opening tag:

https://github.com/datarobot-community/pulumi-datarobot/blob/ca42570c79ff0667343f4a07918956a3c37441ae/docs/_index.md#L13-L15

Can you fix this and create a new release containing this fix?

@NolanJMcCafferty
Copy link
Contributor Author

@ringods Ok I have updated the _index.md file and released the fix.

@cnunciato cnunciato requested a review from a team September 24, 2024 16:20
@cnunciato
Copy link
Contributor

cc @pulumi/docs @sean1588 for a review & merge as I'm currently out.

Copy link
Member

@sean1588 sean1588 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @NolanJMcCafferty! Looks good to me.

@sean1588 sean1588 merged commit fb9ed6b into pulumi:master Sep 24, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants