-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor cmd/metadata.go for clarity #5908
base: master
Are you sure you want to change the base?
Conversation
Would it be possible to put the codebase under test before touching it? I do not see any test files at all around this small codebase. It does not look like a lot is happening here so perhaps the testing itself does not need to be particularly complicated. |
Your site preview for commit 9e6554f is ready! 🎉 http://registry--origin-pr-5908-9e6554fc.s3-website.us-west-2.amazonaws.com/registry. |
9e6554f
to
4e20103
Compare
This simplifies the `PackageMetadataCmd` command.
4e20103
to
3963bac
Compare
Yes. I have rebased on top of f99cca5, which adds tests for this functionality. |
Your site preview for commit 3963bac is ready! 🎉 http://registry--origin-pr-5908-3963bac1.s3-website.us-west-2.amazonaws.com/registry. |
Your site preview for commit 4e20103 is ready! 🎉 http://registry--origin-pr-5908-4e20103e.s3-website.us-west-2.amazonaws.com/registry. |
Description
This PR is best reviewed commit by commit:
repoSlug
parsing into{owner}/{name}
into it's own type.mainSpec
a file local variable.☝️ are pure refactors, and will not change behavior.
a/b
where botha
andb
are non-empty. Previously/
would have been accepted.