Don't allow the Sentinel job to be skipped #6616
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flostadler
approved these changes
Feb 6, 2025
iwahbe
force-pushed
the
iwahbe/dont-allow-sentinel-to-be-skipped
branch
from
908b5f1 to
a7ce2f8
Compare
|
Your site preview for commit a7ce2f8 is ready! 🎉 http://registry--origin-pr-6616-a7ce2f8e.s3-website.us-west-2.amazonaws.com/registry. |
`sentinel` exists to provide a singular stable "required" CI job for auto-merge. When a job that `sentinel` needs fails, then `sentinel` is skipped and auto-merges happen.
iwahbe
force-pushed
the
iwahbe/dont-allow-sentinel-to-be-skipped
branch
from
a7ce2f8 to
b341668
Compare
|
Your site preview for commit b341668 is ready! 🎉 http://registry--origin-pr-6616-b3416689.s3-website.us-west-2.amazonaws.com/registry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sentinelexists to provide a singular stable "required" CI job for auto-merge. When a job thatsentinelneeds fails, thensentinelis skipped and auto-merges happen.The
&& always()removes the implicit dependency check before running the job.