Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: fix TestIntegration#server_gets - until, not unless #3549

Merged
merged 1 commit into from
Nov 11, 2024

Conversation

MSP-Greg
Copy link
Member

Description

I think this was an error I caused last year, where unless was used, but until was intended.

This may help with errors like:

Error: Errno::EBADF: Waiting for server to log /(?:Master| ) PID: (\d+)$/

Your checklist for this pull request

  • I have reviewed the guidelines for contributing to this repository.
  • I have added (or updated) appropriate tests if this PR fixes a bug or adds a feature.
  • My pull request is 100 lines added/removed or less so that it can be easily reviewed.
  • If this PR doesn't need tests (docs change), I added [ci skip] to the title of the PR.
  • If this closes any issues, I have added "Closes #issue" to the PR description or my commit messages.
  • I have updated the documentation accordingly.
  • All new and existing tests passed, including Rubocop.

@MSP-Greg MSP-Greg merged commit 450784a into puma:master Nov 11, 2024
78 checks passed
@MSP-Greg MSP-Greg deleted the 00-server-gets-until branch November 11, 2024 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants