Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds Level 3 flow, cleans up parameters for Level 1, fixes deficient pixel uncertainty #139

Merged
merged 7 commits into from
Apr 17, 2024

Conversation

jmbhughes
Copy link
Member

@jmbhughes jmbhughes commented Apr 16, 2024

PR summary

  • Adds a basic Level 3 flow
  • Cleans up the Level 1 flow to take calibration paths instead of PUNCHData
  • Fixes deficient pixel uncertainty direction
  • adds codecov yaml

Associated issue number: closes #134

Todos

  • make sure tests pass
  • add documentation for deficient pixel

before the calibration could be a PUNCHData or a string... let's be consistent
@jmbhughes jmbhughes self-assigned this Apr 16, 2024
the tests were failing because they tested the task, which now expects a path. To fix this, I just made a separate function that has the loaded deficient pixel map
if all the pixels are deficient, you cannot correct. so I added a check for that. There may be more edge cases to consider too
Copy link

codecov bot commented Apr 17, 2024

Codecov Report

Attention: Patch coverage is 89.61039% with 8 lines in your changes are missing coverage. Please review.

Project coverage is 93.65%. Comparing base (468edb4) to head (776fec3).
Report is 2 commits behind head on main.

❗ Current head 776fec3 differs from pull request most recent head c9d465f. Consider uploading reports for the commit c9d465f to get more accurate results

Files Patch % Lines
punchbowl/level1/deficient_pixel.py 80.95% 4 Missing ⚠️
punchbowl/level3/f_corona_model.py 69.23% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #139      +/-   ##
==========================================
- Coverage   94.17%   93.65%   -0.53%     
==========================================
  Files          28       28              
  Lines        1820     1812       -8     
==========================================
- Hits         1714     1697      -17     
- Misses        106      115       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jmbhughes jmbhughes changed the title Adds Level 3 flow, cleans up parameters for Level 1 Adds Level 3 flow, cleans up parameters for Level 1, fixes deficient pixel uncertainty Apr 17, 2024
@jmbhughes jmbhughes merged commit 437085e into main Apr 17, 2024
1 check passed
@jmbhughes jmbhughes deleted the start-l3-flow branch April 17, 2024 00:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Investigate and fix reversal of uncertainty in deficient pixel module
1 participant