Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle distortion io #218

Merged
merged 8 commits into from
Aug 7, 2024
Merged

Handle distortion io #218

merged 8 commits into from
Aug 7, 2024

Conversation

jmbhughes
Copy link
Member

@jmbhughes jmbhughes commented Aug 7, 2024

PR summary

Rewrites ndcube io to handle distortion

Todos

  • fix omits and such for the WCS section in all the yamls, not needed!
  • make sure RSUN_ARC, SOLAR_EP, and CAR_ROT are set

Test plan

Watch CI and add tests for coverage

Breaking changes

None

Related Issues

None

@jmbhughes jmbhughes self-assigned this Aug 7, 2024
Copy link

codecov bot commented Aug 7, 2024

Codecov Report

Attention: Patch coverage is 90.35088% with 11 lines in your changes missing coverage. Please review.

Project coverage is 90.99%. Comparing base (22ac4c3) to head (075ac35).

Files Patch % Lines
punchbowl/data/meta.py 80.00% 9 Missing ⚠️
punchbowl/data/io.py 83.33% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #218      +/-   ##
==========================================
- Coverage   91.80%   90.99%   -0.82%     
==========================================
  Files          40       40              
  Lines        2380     2420      +40     
==========================================
+ Hits         2185     2202      +17     
- Misses        195      218      +23     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jmbhughes jmbhughes merged commit 17138a9 into main Aug 7, 2024
2 checks passed
@jmbhughes jmbhughes deleted the handle-distortion-io branch August 7, 2024 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant