Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes wcs conversions #226

Merged
merged 10 commits into from
Aug 15, 2024
Merged

Fixes wcs conversions #226

merged 10 commits into from
Aug 15, 2024

Conversation

jmbhughes
Copy link
Member

@jmbhughes jmbhughes commented Aug 15, 2024

PR summary

Fixes wcs conversions to be valid for non Sun centered images

Todos

  • clean up the changes

Test plan

Look at simpunch results. Makes sure current tests pass.

Breaking changes

None

Related Issues

None

@jmbhughes jmbhughes self-assigned this Aug 15, 2024
Copy link

codecov bot commented Aug 15, 2024

Codecov Report

Attention: Patch coverage is 94.73684% with 7 lines in your changes missing coverage. Please review.

Project coverage is 92.28%. Comparing base (66ea8b7) to head (7a1acc8).
Report is 14 commits behind head on main.

Files Patch % Lines
punchbowl/data/wcs.py 93.84% 4 Missing ⚠️
punchbowl/level1/stray_light.py 80.00% 2 Missing ⚠️
punchbowl/level1/vignette.py 94.11% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #226      +/-   ##
==========================================
+ Coverage   91.03%   92.28%   +1.24%     
==========================================
  Files          40       41       +1     
  Lines        2433     2527      +94     
==========================================
+ Hits         2215     2332     +117     
+ Misses        218      195      -23     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jmbhughes jmbhughes merged commit 5868219 into main Aug 15, 2024
4 checks passed
@jmbhughes jmbhughes deleted the fix-wcs branch August 15, 2024 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants