NumPy 2.0+ compatibility #254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #254 +/- ##
=======================================
Coverage 90.26% 90.26%
=======================================
Files 44 44
Lines 2907 2907
=======================================
Hits 2624 2624
Misses 283 283 ☔ View full report in Codecov by Sentry. |
jmbhughes
requested changes
Oct 22, 2024
There was a problem hiding this comment.
I love seeing more CI passing!
One note, it's probably best to use something like np.isposinf instead of checking for equality to np.inf. I'm not sure if it's well defined to just use == for that. My instinct says no.
|
Also, the 3.13 CI taking forever to get dependencies may be because regularizepsf or some other dependency that needs compilation doesn't have a wheel yet for that Python version. |
jmbhughes
approved these changes
Oct 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR summary
Makes code / test changes for compatibility with numpy 2.0+
Todos