Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds visualization core #297

Merged
merged 7 commits into from
Nov 12, 2024
Merged

adds visualization core #297

merged 7 commits into from
Nov 12, 2024

Conversation

jmbhughes
Copy link
Member

@jmbhughes jmbhughes commented Nov 7, 2024

PR summary

  • Adds colormap

Todos

  • add encode to jpeg2000 with nice presets for punch data
  • include tests?
  • update associated documentation website entry - save for later.

closes #183

@jmbhughes
Copy link
Member Author

Here you go as a starting point @lowderchris. Ruff is very unhappy right now, but it should be easy to fix.

Copy link

codecov bot commented Nov 11, 2024

Codecov Report

Attention: Patch coverage is 98.93617% with 1 line in your changes missing coverage. Please review.

Project coverage is 90.00%. Comparing base (27d6c02) to head (7479ec8).
Report is 244 commits behind head on main.

Files with missing lines Patch % Lines
punchbowl/data/io.py 94.44% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #297      +/-   ##
==========================================
+ Coverage   89.49%   90.00%   +0.51%     
==========================================
  Files          45       47       +2     
  Lines        2932     3013      +81     
==========================================
+ Hits         2624     2712      +88     
+ Misses        308      301       -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lowderchris lowderchris marked this pull request as ready for review November 11, 2024 22:41
@lowderchris
Copy link
Contributor

Made some initial implementation for writing to jpeg2000. Still need to pass optional parameters for visualization parameters, and consider writing metadata to file as well.

@lowderchris lowderchris self-requested a review November 11, 2024 23:58
@lowderchris lowderchris merged commit 2207bc0 into main Nov 12, 2024
5 of 6 checks passed
@lowderchris lowderchris deleted the visualizations branch November 12, 2024 00:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create PUNCH color map
2 participants