Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When generating WCSes, set NAXIS/array_shape/etc. #320

Merged
merged 1 commit into from
Nov 22, 2024

Conversation

svank
Copy link
Contributor

@svank svank commented Nov 22, 2024

PR summary

Ran into this when testing a remove_starfield speedup---generated WCSes don't have their NAXISN keywords set, and therefore don't have pixel_shape or array_shape. On the remove_starfield side that can and should and now is handled. But this seems like a might-as-well-have on the punchbowl side.

Copy link

codecov bot commented Nov 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.32%. Comparing base (79c49dc) to head (5afc7c5).
Report is 112 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #320   +/-   ##
=======================================
  Coverage   88.31%   88.32%           
=======================================
  Files          56       56           
  Lines        3740     3742    +2     
=======================================
+ Hits         3303     3305    +2     
  Misses        437      437           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jmbhughes
Copy link
Member

There are more spots in punchbowl this matters, so I'll open an issue.

@jmbhughes jmbhughes merged commit 7ce4df7 into main Nov 22, 2024
7 of 8 checks passed
@jmbhughes jmbhughes deleted the put-naxis-in-celestial-frames branch November 22, 2024 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants