Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create starfield estimates that are less distorted #339

Merged
merged 2 commits into from
Dec 7, 2024
Merged

Conversation

svank
Copy link
Contributor

@svank svank commented Dec 5, 2024

PR summary

This requires remove_starfield v0.0.4

This makes a starfield map that doesn't curve up and down. This means less distortion (unsure if that affects the accuracy of the starfield subtraction) and should offer more speed for the map create (since not blowing things up at extreme declination ought to mean fewer output pixels to reprojection while still capturing everything). Likewise, since this should enable smaller maps, it ought to speed up the subtraction step where it's loading in the star map.

Before:
image

After:
image

Todos

None

Test plan

Run it overnight

Copy link

codecov bot commented Dec 5, 2024

Codecov Report

Attention: Patch coverage is 18.18182% with 9 lines in your changes missing coverage. Please review.

Project coverage is 86.15%. Comparing base (8552bb6) to head (52240f8).
Report is 47 commits behind head on main.

Files with missing lines Patch % Lines
punchbowl/level3/stellar.py 18.18% 9 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #339      +/-   ##
==========================================
- Coverage   86.30%   86.15%   -0.16%     
==========================================
  Files          56       56              
  Lines        3789     3798       +9     
==========================================
+ Hits         3270     3272       +2     
- Misses        519      526       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jmbhughes jmbhughes self-requested a review December 5, 2024 09:09
@jmbhughes jmbhughes merged commit 6e02998 into main Dec 7, 2024
6 of 8 checks passed
@jmbhughes jmbhughes deleted the flat-starmap branch December 7, 2024 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants