Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds bright feature detection module #97

Merged
merged 5 commits into from
Mar 11, 2024
Merged

Adds bright feature detection module #97

merged 5 commits into from
Mar 11, 2024

Conversation

mwest007
Copy link
Contributor

@mwest007 mwest007 commented Feb 20, 2024

Updated the task and the bright feature identification is in find spikes

Todos

  • write core detection function
  • write tests for function
  • write documentation page of website
  • integrate into pipeline with task
  • make sure level 2 flow runs
  • open issue to implement punchpipe automation

bright feature task updated
@mwest007 mwest007 requested a review from jmbhughes February 20, 2024 20:43
@mwest007 mwest007 self-assigned this Feb 20, 2024
@mwest007 mwest007 linked an issue Feb 20, 2024 that may be closed by this pull request
@jmbhughes jmbhughes changed the title Bright detection Adds bright feature detection module Feb 21, 2024
@jmbhughes jmbhughes self-assigned this Feb 22, 2024
Copy link

codecov bot commented Mar 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.75%. Comparing base (de0657d) to head (47786d4).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop      #97      +/-   ##
===========================================
+ Coverage    94.67%   94.75%   +0.07%     
===========================================
  Files           28       28              
  Lines         1729     1735       +6     
===========================================
+ Hits          1637     1644       +7     
+ Misses          92       91       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jmbhughes jmbhughes removed their assignment Mar 11, 2024
@jmbhughes jmbhughes merged commit fa24e09 into develop Mar 11, 2024
4 checks passed
@jmbhughes jmbhughes deleted the bright_detection branch March 11, 2024 23:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Write L2BS bright structure identification module
2 participants