Normalize patches by the star-center value rather than the patch maximum #60
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Btw if you're gearing up for another release, there was one last local change I never pushed. When the cutouts of each star are being collected, each one gets normalized. The was done by dividing each patch by its maximum value. In cases where there's some contaminant in the patch that's brighter than the star, the normalized star is in the range [0, small] instead of [0, 1] and so doesn't contribute well to the final PSF model. I changed it to use the patch-center value (i.e. the star's center and presumably peak value) rather than the patch's maximum value, to help ensure that the stars are all normalized the same. Any bright contaminants will be normalized to values > 1, but since they're hopefully rare, that shouldn't really affect the median/percentile/whatever.
If the patch sizes are small, hopefully these contaminants are pretty rare and this is a low-impact change.
What do you think?