Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disabling drag'n'drop on buttons of subitem #119

Closed
dijkstra33 opened this issue Dec 30, 2014 · 7 comments
Closed

Disabling drag'n'drop on buttons of subitem #119

dijkstra33 opened this issue Dec 30, 2014 · 7 comments
Milestone

Comments

@dijkstra33
Copy link

Hi! I have an ItemsControl in wpf with enabled dd(need dd between all elements independently of inclusion level). Some DataTemplates have buttons in it's structure. On first level of inclusion everything works fine, but when we go deeper (-_-): when root ItemsControl have ItemsControl in some DataTemplate, and this 2nd level DataTemplate have buttons in it's structure - I only can click this button with two clicks instead of one: first click is eat by dd.
With deeper levels of inclusion (3rd, 4th etc.) I have the same problem: buttons on this levels can only be clicked by two presses.
Do you have some solution for such a problem ?

@punker76
Copy link
Owner

@dijkstra33 I'll look into.

@punker76 punker76 added this to the v0.1.4.4 milestone Dec 30, 2014
@matelich
Copy link

In my fork (which I keep meaning to submit patches from but I didn't do
them on branches), I made this change which seems related.

I removed a check which prevents drag/drop in nested ItemsControl. I know
this was added intentionally, but I needed it. I haven't noticed any
negative repercussions yet.
matelich@eacc7d8

On Tue, Dec 30, 2014 at 1:00 AM, Jan Karger notifications@github.com
wrote:

@dijkstra33 https://github.com/dijkstra33 I'll look into.


Reply to this email directly or view it on GitHub
#119 (comment)
.

@dijkstra33
Copy link
Author

@matelich your fix didn't help.

punker76 added a commit that referenced this issue Jan 17, 2015
@punker76
Copy link
Owner

@dijkstra33 I can't reproduce your issue. I've added an example ItemsControl with ItemsControl and Buttons. Can you look at this and give me any other tipps?
@matelich That's not the correct solution for it.

@dijkstra33
Copy link
Author

@punker76 here is my example:
https://www.dropbox.com/s/56u6rpv0d567a41/BugSample.zip?dl=0

Sorry, I didn't say about recursiveness in first post.

@punker76
Copy link
Owner

@dijkstra33 i tested your example with the latest 1.0.0 alpha and can't find any problems, so maybe this issue is fixed now...

@dijkstra33
Copy link
Author

@punker76 Yes, you've fixed it. Thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants