Allow target adorners on non-ItemsControls #143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
if VisualTarget is not ItemsControl then VisualTargetItem = VisualTarget. Allows HighlightAdorner to be used in IDropTarget.Drag.
allow adorners on non-ItemControls (e.g. a label representing a collection, who's collection is rendered with it.)
punker76
added a commit
that referenced
this pull request
Oct 8, 2015
Allow target adorners on non-ItemsControls
|
@emsaks thx |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Consider a listbox bound to a collection representing groups of items. You want to drag into the list or in an item. The item implements IDropTarget, and you need it to show HighlightAdorner - but that only works on a valid VisualTargetItem which is only set on ItemsControls. Added code to fallback setting VisualTargetItem = VisualTarget, and checking for target adorner on any target UIElement.