Multiple items deselected in ListView and other subclasses of ListBox #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nd other subclasses of ListBox would lose their selections if multiple items were selected.
punker76
added a commit
that referenced
this pull request
May 28, 2013
Multiple items deselected in ListView and other subclasses of ListBox
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, first of all, many thanks for taking over this project. Here's a little pull request to fix a small bug: whenever I tried to select multiple items from a ListView and drag them, all the items would be deselected, except the single item I actually started dragging.
This was due to a bug in
ItemsControlExtensions.GetSelectedItems():This is too strict - the IsAssignableFromType() is round the wrong way (can you assign a base class to its subclass? no), so it fails to handle ListView and other subclasses of ListBox. My patch simply changes it to an is operator instead.