Skip to content
This repository has been archived by the owner on Apr 17, 2023. It is now read-only.

Ensure pct install scaffolds into the correct folder structure #181

Closed
3 tasks done
michaeltlombardi opened this issue Aug 19, 2021 · 0 comments · Fixed by #197
Closed
3 tasks done

Ensure pct install scaffolds into the correct folder structure #181

michaeltlombardi opened this issue Aug 19, 2021 · 0 comments · Fixed by #197
Assignees
@da-ar @sanfrancrisko
Labels
enhancement New feature or request

Comments

@michaeltlombardi
Copy link
Contributor

michaeltlombardi commented Aug 19, 2021 •
edited by sanfrancrisko
Loading

When installing a Puppet Content Template, the install command should parse the pct-config for that template and place the template into the following folder structure: author/id/version/..., where author, id, and version are pulled from the config file and the contents are placed in the version folder.

Acceptance Criteria

  • If the yaml does not include the author, id, and version keys, it errors
  • If the template would override an existing template with the combination of keys, it errors and suggests using --force to override
  • If the template would override an existing template with the combination of keys and the --force flag is specified, it overwrites the existing template files with a debug message
@michaeltlombardi michaeltlombardi mentioned this issue Aug 25, 2021
Merged
@da-ar da-ar self-assigned this Aug 25, 2021
@da-ar da-ar added the enhancement New feature or request label Aug 25, 2021
da-ar added a commit to da-ar/pdkgo that referenced this issue Aug 31, 2021
@da-ar
(puppetlabs-toy-chestGH-181) Template should install to namespace path
f273ff6 
Prior to this commit, templates were installed to the templates directory under their id. This change sees that templates are installed to a namespaced path using the data contained in `pct-config.yml`

i.e. author/id/version
e.g. puppetlabs/puppet-module-base/1.0.0

This allows for users to customise a template and share under their own namespace. It also allows for the retention of different versions of an installed template.
da-ar added a commit to da-ar/pdkgo that referenced this issue Aug 31, 2021
@da-ar
(puppetlabs-toy-chestGH-181) Template should install to namespace path
b0ec27a 
Prior to this commit, templates were installed to the templates directory under their id. This change sees that templates are installed to a namespaced path using the data contained in `pct-config.yml`

i.e. author/id/version
e.g. puppetlabs/puppet-module-base/1.0.0

This allows for users to customise a template and share under their own namespace. It also allows for the retention of different versions of an installed template.
da-ar added a commit to da-ar/pdkgo that referenced this issue Aug 31, 2021
@da-ar
(puppetlabs-toy-chestGH-181) Template should install to namespace path
70ce2fe 
Prior to this commit, templates were installed to the templates directory under their id. This change sees that templates are installed to a namespaced path using the data contained in `pct-config.yml`
da-ar added a commit to da-ar/pdkgo that referenced this issue Sep 1, 2021
@da-ar
(puppetlabs-toy-chestGH-181) Template should install to namespace path
201f74c 
Prior to this commit, templates were installed to the templates directory under their id. This change sees that templates are installed to a namespaced path using the data contained in `pct-config.yml`
da-ar added a commit to da-ar/pdkgo that referenced this issue Sep 1, 2021
@da-ar
(puppetlabs-toy-chestGH-181) Template should install to namespace path
a500a13 
Prior to this commit, templates were installed to the templates directory under their id. This change sees that templates are installed to a namespaced path using the data contained in `pct-config.yml`
da-ar added a commit to da-ar/pdkgo that referenced this issue Sep 1, 2021
@da-ar
(puppetlabs-toy-chestGH-181) Template should install to namespace path
57d3039 
Prior to this commit, templates were installed to the templates directory under their id. This change sees that templates are installed to a namespaced path using the data contained in `pct-config.yml`
da-ar added a commit to da-ar/pdkgo that referenced this issue Sep 2, 2021
@da-ar
(puppetlabs-toy-chestGH-181) Template should install to namespace path
8ffd803 
Prior to this commit, templates were installed to the templates directory under their id. This change sees that templates are installed to a namespaced path using the data contained in `pct-config.yml`
da-ar added a commit to da-ar/pdkgo that referenced this issue Sep 2, 2021
@da-ar
(puppetlabs-toy-chestGH-181) Add --force flag to install
f7d6a47 
This flag enables a template that already existing in the templatepath to be overwritten.
da-ar added a commit to da-ar/pdkgo that referenced this issue Sep 2, 2021
@da-ar
(puppetlabs-toy-chestGH-181) Add --force flag to install
ec111b7 
This flag enables a template that already existing in the templatepath to be overwritten.
da-ar added a commit to da-ar/pdkgo that referenced this issue Sep 2, 2021
@da-ar
(puppetlabs-toy-chestGH-181) Add --force flag to install
8a56ad9 
This flag enables a template that already existing in the templatepath to be overwritten.
da-ar added a commit to da-ar/pdkgo that referenced this issue Sep 2, 2021
@da-ar
(puppetlabs-toy-chestGH-181) Add --force flag to install
7ad4bd0 
This flag enables a template that already existing in the templatepath to be overwritten.
da-ar added a commit to da-ar/pdkgo that referenced this issue Sep 2, 2021
@da-ar
(puppetlabs-toy-chestGH-181) Add --force flag to install
1162f7e 
This flag enables a template that already existing in the templatepath to be overwritten.
da-ar added a commit to da-ar/pdkgo that referenced this issue Sep 3, 2021
@da-ar
(puppetlabs-toy-chestGH-181) Add --force flag to install
589f8af 
This flag enables a template that already existing in the templatepath to be overwritten.
da-ar added a commit to da-ar/pdkgo that referenced this issue Sep 3, 2021
@da-ar
(puppetlabs-toy-chestGH-181) Add --force flag to install
45825cb 
This flag enables a template that already existing in the templatepath to be overwritten.
da-ar added a commit to da-ar/pdkgo that referenced this issue Sep 3, 2021
@da-ar
(puppetlabs-toy-chestGH-181) Add --force flag to install
cbff12c 
This flag enables a template that already existing in the templatepath to be overwritten.
da-ar added a commit to da-ar/pdkgo that referenced this issue Sep 3, 2021
@da-ar
(puppetlabs-toy-chestGH-181) Add --force flag to install
6104657 
This flag enables a template that already existing in the templatepath to be overwritten.
da-ar added a commit to da-ar/pdkgo that referenced this issue Sep 3, 2021
@da-ar
(puppetlabs-toy-chestGH-181) Add --force flag to install
b592da0 
This flag enables a template that already existing in the templatepath to be overwritten.
@sanfrancrisko sanfrancrisko self-assigned this Sep 7, 2021
@sanfrancrisko sanfrancrisko linked a pull request Sep 7, 2021 that will close this issue
(GH-181) pct install to namespaced location #197
Merged
michaeltlombardi added a commit that referenced this issue Sep 7, 2021
@michaeltlombardi
Merge pull request #197 from da-ar/GH-181/main/install-location
b62e89c 
(GH-181) `pct install` to namespaced location
sanfrancrisko pushed a commit that referenced this issue Sep 8, 2021
Merge pull request #199 from michaeltlombardi/gh-181/main/find-new-la…
0bc3e4d 
…yout

(GH-182) Find templates in new install folder structure
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@da-ar da-ar

@sanfrancrisko sanfrancrisko

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

(GH-181) pct install to namespaced location da-ar/pdkgo
3 participants
@da-ar @michaeltlombardi @sanfrancrisko