Skip to content
This repository has been archived by the owner on Apr 17, 2023. It is now read-only.
This repository has been archived by the owner on Apr 17, 2023. It is now read-only.

Cache PCT templates in pct new preExecute method #201

Closed
3 tasks done
sanfrancrisko opened this issue Sep 8, 2021 · 0 comments · Fixed by #202
Closed
3 tasks done

Cache PCT templates in pct new preExecute method #201

sanfrancrisko opened this issue Sep 8, 2021 · 0 comments · Fixed by #202
Assignees
@michaeltlombardi @sanfrancrisko
Labels
enhancement New feature or request

Comments

@sanfrancrisko
Copy link

sanfrancrisko commented Sep 8, 2021 •
edited
Loading

Given we will be invoking pct.List numerous times when using the pct new command, we should only visit the template cache once and cache the results.

Acceptance Criteria:

  • Call pct.List from the preExecute stage in the new Cobra command and cache the results
  • Ensure completeName method references cache instead of invoking pct.List
  • Ensure execute method references cache instead of invoking pct.List
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@michaeltlombardi michaeltlombardi

@sanfrancrisko sanfrancrisko

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

(GH-201) Cache PCT templates in pct new preExecute method
2 participants
@michaeltlombardi @sanfrancrisko