This repository has been archived by the owner on Apr 17, 2023. It is now read-only.
(GH-136) Install template from git repo #249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petergmurphy
changed the title
sanfrancrisko
suggested changes
Oct 8, 2021
petergmurphy
force-pushed
the
gh-136/main/install_template_from_git_repo
branch
2 times, most recently
from
2f64eb2
to
7696f29
Compare
da-ar
reviewed
Oct 12, 2021
|
Could you provide a link to an example template repo in the PR description |
Yes, links to the example template repositories used for testing have been added to the PR description. |
petergmurphy
force-pushed
the
gh-136/main/install_template_from_git_repo
branch
2 times, most recently
from
b658b69
to
bfe9bc6
Compare
added 4 commits
October 13, 2021 10:10
Added `--git-uri` flag that takes a string variable as its argument. Modified existing code in the `executeInstall` method so that it checks if the `--git-uri` flag is being used. The appropriate function for template installation will be called based on this check. `preExecute` function changed to provide the correct template installation path for the `--git-uri` flag. Implemented functions that allow for the cloning of templates from a remote repository using a git URI. Added unit and acceptance tests where relevant. Added appropriate documentation to `CHANGELOG.md` and `README.md`.
petergmurphy
force-pushed
the
gh-136/main/install_template_from_git_repo
branch
from
bfe9bc6
to
f497dc9
Compare
sanfrancrisko
approved these changes
Oct 13, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview of PR:
--git-uriflag followed by a git URI as a string argument to install a template from a git repository by cloning it.pct-config.ymlandcontentdirectory). Also checks that the URI is valid.pct-config.ymlfile is read and template is installed into its corresponding namespace directory..gitfolder removed from installation directory after template is installed..ideadirectory, pertaining to the GoLand IDE, to gitignore.Templates used for testing functionality: