This repository was archived by the owner on Apr 17, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 5
(maint) Add additional quality checks via gh actions #58
Merged
jpogran
merged 6 commits into
puppetlabs-toy-chest:main
from
da-ar:maint/main/formatting
Jun 9, 2021
Merged
(maint) Add additional quality checks via gh actions #58
jpogran
merged 6 commits into
puppetlabs-toy-chest:main
from
da-ar:maint/main/formatting
Jun 9, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bd8e645
to
04592df
Compare
e016dcd
to
d823897
Compare
jpogran
reviewed
Jun 2, 2021
jpogran
reviewed
Jun 2, 2021
jpogran
reviewed
Jun 2, 2021
jpogran
reviewed
Jun 2, 2021
4b8ade1
to
bc7f64e
Compare
sanfrancrisko
approved these changes
Jun 4, 2021
bc7f64e
to
efb11ac
Compare
jpogran
approved these changes
Jun 7, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved! Please also create a ticket to handle the makefile cross platform
This action adds, coverage reporting, security checking, lint checking, formatting and dependency checking
This wont work for PRs raised from a fork. See for more details: actions/labeler#50
efb11ac
to
1eaefab
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran
go fmt
and updated a lot of files. Adding this action (borrowed from comply) which will give us an early warning about code quality issues.This can wait until after our first LA release