Skip to content
This repository was archived by the owner on Apr 17, 2023. It is now read-only.

(maint) Add additional quality checks via gh actions #58

Merged
merged 6 commits into from
Jun 9, 2021

Conversation

da-ar
Copy link

@da-ar da-ar commented May 25, 2021

I ran go fmt and updated a lot of files. Adding this action (borrowed from comply) which will give us an early warning about code quality issues.

This can wait until after our first LA release

@da-ar da-ar force-pushed the maint/main/formatting branch from bd8e645 to 04592df Compare May 25, 2021 10:30
@da-ar da-ar force-pushed the maint/main/formatting branch 5 times, most recently from e016dcd to d823897 Compare June 2, 2021 16:53
@da-ar da-ar marked this pull request as ready for review June 2, 2021 16:56
@da-ar da-ar requested a review from a team as a code owner June 2, 2021 16:56
@da-ar da-ar force-pushed the maint/main/formatting branch 2 times, most recently from 4b8ade1 to bc7f64e Compare June 3, 2021 13:50
@da-ar da-ar force-pushed the maint/main/formatting branch from bc7f64e to efb11ac Compare June 4, 2021 11:11
Copy link
Contributor

@jpogran jpogran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved! Please also create a ticket to handle the makefile cross platform

da-ar added 6 commits June 9, 2021 15:51
This action adds, coverage reporting, security checking, lint checking, formatting and dependency checking
This wont work for PRs raised from a fork.
See for more details: actions/labeler#50
@da-ar da-ar force-pushed the maint/main/formatting branch from efb11ac to 1eaefab Compare June 9, 2021 14:56
@jpogran jpogran merged commit b8d3a8c into puppetlabs-toy-chest:main Jun 9, 2021
@da-ar da-ar deleted the maint/main/formatting branch June 9, 2021 15:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants