Ensure post-suite and destroy execute #238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We need to run the post-suite even if pre-suite fails (for example in cases where the agent fails to install) |
The `ci:test:aio` rake task would skip the `post-suite` if any presuites or tests failed. Now the `post-suite` is protected in a nested ensure block so if `provision` succeeds, then the `post-suite` is guaranteed to be called. This is important in order to capture failures when installing the agent during the `pre-suite`. And due to the nested ensure, if the `post-suite` fails, then `destroy` will also be guaranteed to be called. ``` $ export BEAKER_PUPPET_VERSION=/home/josh/work/beaker-puppet $ bundle update $ bundle exec rake 'ci:test:aio[true]' SHA=8.4.0 TESTS=tests/load_libfacter.rb HOSTS=hosts.yaml ... Begin tests/load_libfacter.rb C100161: Ruby can load libfacter without raising an error RuntimeError: Whoops /home/josh/work/facter/acceptance/tests/load_libfacter.rb:5 ... beaker exec post-suite ... Begin teardown/common/099_Archive_Logs.rb ```
When running `rake ci:test:aio[true]`, if the post-suite failed and we're not
preserving hosts, then the `beaker destroy` command would be skipped. Use a
nested ensure so the failure of post-suite doesn't prevent `beaker destroy` from
being called.
The nested ensure also guarantees that the `post-suite` will be called even if
the `pre-suite` fails, which can happen if the agent fails to install. This
matches the behavior for the "non-retry" version of the `ci:test:aio` rake task.
```
$ git diff
diff --git a/acceptance/teardown/common/099_Archive_Logs.rb b/acceptance/teardown/common/099_Archive_Logs.rb
index d940e2bea..2302633e1 100644
--- a/acceptance/teardown/common/099_Archive_Logs.rb
+++ b/acceptance/teardown/common/099_Archive_Logs.rb
@@ -1,5 +1,7 @@
require 'date'
+raise "whoops"
+
def file_glob(host, path)
result = on(host, "ls #{path}", :acceptable_exit_codes => [0, 2])
return [] if result.exit_code != 0
$ export BEAKER_PUPPET_VERSION=/home/josh/work/beaker-puppet
$ bundle update
...
$ bundle exec rake 'ci:test:aio[true]' SHA=8.4.0 TESTS=tests/load_libfacter.rb HOSTS=hosts.yaml
...
Begin teardown/common/099_Archive_Logs.rb
RuntimeError: whoops
...
beaker destroy
```
joshcooper
force-pushed
the
ensure-post-suite
branch
from
aece90c
to
1d6b1d9
Compare
tvpartytonight
approved these changes
Jan 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running
ci:test:aiomake surebeaker exec post-suiteexecutesWhen running
ci:test:aio[true]make surebeaker destroyexecutesFixes #237