Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIXES #3229 Require bundler 2.3.4+ to fix deprecation warning #3230

Merged
merged 2 commits into from
Sep 6, 2023

Conversation

tlehman
Copy link
Contributor

@tlehman tlehman commented Sep 5, 2023

Upgrading to bundler 2.3.4 or above fixes the

Calling `DidYouMean::SPELL_CHECKERS.merge!(error_name => spell_checker)' has been deprecated. Please call `DidYouMean.correct_error(error_name, spell_checker)' instead.

error. In order to apply this change with a locally built bolt:

  1. delete Gemfile.lock
  2. delete modules/**/*
  3. upgrade bundler gem install bundler -v '2.3.4'
  4. confirm that bundle -v returns the correct version
  5. if 4 is confirmed, then
    5a. bundle install
    5b. bundle exec r10k puppetfile install Puppetfile

@tlehman tlehman requested a review from a team as a code owner September 5, 2023 21:18
@tlehman
Copy link
Contributor Author

tlehman commented Sep 5, 2023

The failed task said

Your Ruby version is 2.7.8, but your Gemfile specified 2.7.7
Error: The process '/opt/hostedtoolcache/Ruby/2.7.8/x64/bin/bundle' failed with exit code 18

fixing now.

@justinstoller
Copy link
Member

I didn't know you could set the bundler version like that, is it well supported?

Copy link
Member

@justinstoller justinstoller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to do what it says on the tin.

@mcdonaldseanp mcdonaldseanp merged commit 6d12f08 into puppetlabs:main Sep 6, 2023
41 checks passed
@tlehman tlehman deleted the issue-3229 branch September 6, 2023 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants