(maint) Log broker WS URI on open event #116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This needs puppetlabs/pxp-agent#244. |
|
Merging this means we'll have to branch cpp-pcp-client if we need any more fixes for pxp-agent stable. |
|
@MikaelSmith why would we have an additional branch for cpp-pcp-client? I didn't follow that. Related, should both these logging changes go to stable? |
|
@kylog would be nice to have them, but @joshcooper asked to avoid merging into stable today. |
|
Ah okay, got it. Thanks. |
|
I meant, if we need to make fixes to cpp-pcp-client needed by pxp-agent#stable before we merge pxp-agent#master up to stable, we'll have to branch this to add the fixes and do another cpp-pcp-client bug fix release. That's a problem we can deal with when it arises, so just thinking it through. |
ploubser
added a commit
that referenced
this pull request
Nov 17, 2015
(maint) Log broker WS URI on open event
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.