This repository has been archived by the owner on Jun 19, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 24
(FACT-2635) Incorrect output for non existing fact #536
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oanatmaria
reviewed
Jun 2, 2020
gimmyxd
reviewed
Jun 2, 2020
…alue` API methods.
oanatmaria
reviewed
Jun 3, 2020
spec/framework/core/fact/internal/internal_fact_manager_spec.rb
Outdated
Show resolved
Hide resolved
oanatmaria
approved these changes
Jun 3, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When querying for two facts, one that exists and one that does not, Facter 4 outputs only the fact that exists. It should output both facts, the one that does not exist with nil (or empty depending on the formatter) value
e.g. no fix
e.g. with fix