This repository has been archived by the owner on Jun 19, 2020. It is now read-only.
Use proper encoding #539
Merged
Use proper encoding #539
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
|
@faucct the PR looks good, great work! The coverage error is from our CI (we have an issue with external forks trying to use secrets) |
BogdanIrimie
approved these changes
Jun 9, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Command
system_profiler SPHardwareDataType SPSoftwareDataTypeoutputsUTF-8data. For example, default value ofComputer Namehas a—symbol, which does not fitASCII:Here is a working fix.
Also there is something wrong with error reporting, as it was impossible to debug it without monkey-patching the code. The error was
ArgumentError (invalid byte sequence in US-ASCII), but here is what it looked like when I was enabling--debug: