(FACT-3154) Adds Ruby 3.2 to rspec tests #2525
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhashizume
force-pushed
the
FACT-3154/main/ruby_3_2
branch
7 times, most recently
from
90e3fc1 to
592ed0a
Compare
|
This PR does not add Ruby 3.2.0 preview builds to Windows tests as they are not yet available through the |
joshcooper
reviewed
Oct 7, 2022
In preparation for Puppet 8, which will likely use Ruby 3.2, this commit adds Ruby 3.2.0-preview2 to the rspec test matrix.
The File.exists? method was deprecated in Ruby 2.1.0: https://github.com/ruby/ruby/blob/6d728bdae9de565ad9d0b2fee2d4c2a33c6f4eac/file.c#L1414 And removed entirely from 3.2.0 onward: https://bugs.ruby-lang.org/issues/17391 This commit updates that method to File.exist? in the directory loader spec tests.
Prior to this commit, the `mac_from` method would implicitly return a logging object when rescuing an error when it should return nil. This commit updates the method to correctly return nil when rescuing an error, which fixes some failing tests in Ruby >= 3.2.0.
There is a bug in timecop in how it interacts with newer versions of Psych that causes our YAML parser date spec to fail. This commit sets this test as pending until we can find a long- term resolution. travisjeffery/timecop#390
mhashizume
force-pushed
the
FACT-3154/main/ruby_3_2
branch
from
592ed0a to
2c5e35f
Compare
joshcooper
approved these changes
Oct 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In preparation for Puppet 8, which will likely use Ruby 3.2, this commit adds Ruby 3.2.0-preview1 to the rspec test matrix.